Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h

Issue 1099403005: [AiS] changing mac omnibox suggestions form NSMatrix to NSTableView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review changes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h
index 3bfd3c2cc08b5c48cf702beb58a14dfb52363eb4..e97e2a74b40f2bad9f0eb4b31c6ccd0c721126ab 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h
@@ -10,6 +10,26 @@
#import "ui/base/cocoa/tracking_area.h"
#include "ui/base/window_open_disposition.h"
+@class OmniboxPopupCell;
+
+@interface OmniboxPopupTableController
+ : NSViewController<NSTableViewDelegate, NSTableViewDataSource> {
+ @private
+ base::scoped_nsobject<NSArray> array_;
+ NSInteger hovered_index_;
+};
+
+// Set the hovered highlight.
+- (void)highlightRowAt:(NSInteger)rowIndex withView:(NSView*)view;
+
+// Which row has the hovered highlight.
+- (NSInteger)highlightedRow;
+
+// Get the drawing rectangle for the given row.
+- (NSRect)rectForRow:(NSInteger)rowIndex;
+
+@end
+
@class OmniboxPopupMatrix;
class OmniboxPopupMatrixObserver {
@@ -27,9 +47,10 @@ class OmniboxPopupMatrixObserver {
// Sets up a tracking area to implement hover by highlighting the cell the mouse
// is over.
-@interface OmniboxPopupMatrix : NSMatrix {
+@interface OmniboxPopupMatrix : NSTableView {
OmniboxPopupMatrixObserver* observer_; // weak
ui::ScopedCrTrackingArea trackingArea_;
+ base::scoped_nsobject<OmniboxPopupTableController> controller_;
}
// Create a zero-size matrix.
@@ -41,6 +62,12 @@ class OmniboxPopupMatrixObserver {
// Return the currently highlighted row. Returns -1 if no row is highlighted.
- (NSInteger)highlightedRow;
+// Move the selection to |rowIndex|.
+- (void)selectRowAt:(NSInteger)rowIndex;
+
+// Setup the information used by the NSTableView data source.
+- (void)setDataArray:(NSArray*)array;
+
@end
#endif // CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_MATRIX_H_

Powered by Google App Engine
This is Rietveld 408576698