[AiS] changing mac omnibox suggestions form NSMatrix to NSTableView

chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm
index e4bb64b0d6493831e6bd7e8d7a63fbd022aa9600..d436ddcc0916d09c75ddf6effb31feffb5138500 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm
@@ -17,31 +17,31 @@ class OmniboxPopupCellTest : public CocoaTest {
   void SetUp() override {
     CocoaTest::SetUp();
     cell_.reset([[OmniboxPopupCell alloc] initTextCell:@""]);
-    button_.reset([[NSButton alloc] initWithFrame:NSMakeRect(0, 0, 200, 20)]);
-    [button_ setCell:cell_];
-    [[test_window() contentView] addSubview:button_];
+    control_.reset([[NSControl alloc] initWithFrame:NSMakeRect(0, 0, 200, 20)]);
+    [control_ setCell:cell_];
+    [[test_window() contentView] addSubview:control_];

[Scott Hess - ex-Googler, 2015/05/07 22:35:42]

Feel free to embiggen these tests.  At some point the goal in here was just to
make sure it was passing very basic functionality, like setters and getters
don't freak out, but I think the cell got more complicated without any attention
to the tests.

[No need for this CL, you're not making it worse, but as long as you're in here
for a few days/weeks, might as well make it better.]

[dschuyler, 2015/05/13 01:41:11]

Acknowledged.

   };
 
  protected:
   base::scoped_nsobject<OmniboxPopupCell> cell_;
-  base::scoped_nsobject<NSButton> button_;
+  base::scoped_nsobject<NSControl> control_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(OmniboxPopupCellTest);
 };
 
-TEST_VIEW(OmniboxPopupCellTest, button_);
+TEST_VIEW(OmniboxPopupCellTest, control_);
 
 TEST_F(OmniboxPopupCellTest, Image) {
   [cell_ setImage:[NSImage imageNamed:NSImageNameInfo]];
-  [button_ display];
+  [control_ display];
 }
 
 TEST_F(OmniboxPopupCellTest, Title) {
   base::scoped_nsobject<NSAttributedString> text([[NSAttributedString alloc]
       initWithString:@"The quick brown fox jumps over the lazy dog."]);
   [cell_ setAttributedTitle:text];
-  [button_ display];
+  [control_ display];
 }
 
 }  // namespace