Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Side by Side Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix_unittest.mm

Issue 1099403005: [AiS] changing mac omnibox suggestions form NSMatrix to NSTableView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed cell data rect Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h"
5 #import "chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h" 6 #import "chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h"
6 7
7 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h" 8 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
8 #import "ui/events/test/cocoa_test_event_utils.h" 9 #import "ui/events/test/cocoa_test_event_utils.h"
9 10
10 namespace { 11 namespace {
11 12
12 NSEvent* MouseEventInRow(NSMatrix* matrix, NSEventType type, NSInteger row) { 13 NSEvent* MouseEventInRow(OmniboxPopupMatrix* matrix,
13 NSRect cell_rect = [matrix cellFrameAtRow:row column:0]; 14 NSEventType type,
15 NSInteger row) {
16 NSRect cell_rect = [matrix rectOfRow:row];
14 NSPoint point_in_view = NSMakePoint(NSMidX(cell_rect), NSMidY(cell_rect)); 17 NSPoint point_in_view = NSMakePoint(NSMidX(cell_rect), NSMidY(cell_rect));
15 NSPoint point_in_window = [matrix convertPoint:point_in_view toView:nil]; 18 NSPoint point_in_window = [matrix convertPoint:point_in_view toView:nil];
16 return cocoa_test_event_utils::MouseEventAtPoint( 19 return cocoa_test_event_utils::MouseEventAtPoint(
17 point_in_window, type, 0); 20 point_in_window, type, 0);
18 } 21 }
19 22
20 class OmniboxPopupMatrixTest : public CocoaTest, 23 class OmniboxPopupMatrixTest : public CocoaTest,
21 public OmniboxPopupMatrixObserver { 24 public OmniboxPopupMatrixObserver {
22 public: 25 public:
23 OmniboxPopupMatrixTest() 26 OmniboxPopupMatrixTest()
24 : selected_row_(0), 27 : selected_row_(0), clicked_row_(0), middle_clicked_row_(0) {}
25 clicked_row_(0),
26 middle_clicked_row_(0) {
27 }
28 28
29 void SetUp() override { 29 void SetUp() override {
30 CocoaTest::SetUp(); 30 CocoaTest::SetUp();
31 matrix_.reset([[OmniboxPopupMatrix alloc] initWithObserver:this]); 31 matrix_.reset([[OmniboxPopupMatrix alloc] initWithObserver:this]);
32 [[test_window() contentView] addSubview:matrix_]; 32 [[test_window() contentView] addSubview:matrix_];
33
34 base::scoped_nsobject<NSTableColumn> column(
35 [[NSTableColumn alloc] initWithIdentifier:@"MainCell"]);
36 [column setDataCell:[[[OmniboxPopupCell alloc] init] autorelease]];
37 [matrix_ addTableColumn:column];
38
39 NSMutableArray* array = [NSMutableArray array];
40 CGFloat popupHeight = 0;
41 for (size_t ii = 0; ii < 3; ++ii) {
42 base::scoped_nsobject<OmniboxPopupCellData> cellData(
43 [[OmniboxPopupCellData alloc] init]);
44 [array addObject:cellData];
45 popupHeight += [cellData rowHeight];
46 }
47 [matrix_ setDataArray:array];
48 [matrix_ reloadData];
49
50 NSRect table_frame = NSZeroRect;
51 CGFloat testWidth = 400;
52 table_frame.size.width = testWidth;
53 table_frame.size.height = popupHeight;
54 [matrix_ setFrame:table_frame];
33 }; 55 };
34 56
35 void OnMatrixRowSelected(OmniboxPopupMatrix* matrix, size_t row) override { 57 void OnMatrixRowSelected(OmniboxPopupMatrix* matrix, size_t row) override {
36 selected_row_ = row; 58 selected_row_ = row;
37 [matrix_ selectCellAtRow:row column:0];
38 } 59 }
39 60
40 void OnMatrixRowClicked(OmniboxPopupMatrix* matrix, size_t row) override { 61 void OnMatrixRowClicked(OmniboxPopupMatrix* matrix, size_t row) override {
41 clicked_row_ = row; 62 clicked_row_ = row;
42 } 63 }
43 64
44 void OnMatrixRowMiddleClicked(OmniboxPopupMatrix* matrix, 65 void OnMatrixRowMiddleClicked(OmniboxPopupMatrix* matrix,
45 size_t row) override { 66 size_t row) override {
46 middle_clicked_row_ = row; 67 middle_clicked_row_ = row;
47 } 68 }
48 69
49 protected: 70 protected:
50 base::scoped_nsobject<OmniboxPopupMatrix> matrix_; 71 base::scoped_nsobject<OmniboxPopupMatrix> matrix_;
51 size_t selected_row_; 72 size_t selected_row_;
52 size_t clicked_row_; 73 size_t clicked_row_;
53 size_t middle_clicked_row_; 74 size_t middle_clicked_row_;
54 75
55 private: 76 private:
56 DISALLOW_COPY_AND_ASSIGN(OmniboxPopupMatrixTest); 77 DISALLOW_COPY_AND_ASSIGN(OmniboxPopupMatrixTest);
57 }; 78 };
58 79
59 TEST_VIEW(OmniboxPopupMatrixTest, matrix_); 80 TEST_VIEW(OmniboxPopupMatrixTest, matrix_);
60 81
61 TEST_F(OmniboxPopupMatrixTest, HighlightedRow) { 82 TEST_F(OmniboxPopupMatrixTest, HighlightedRow) {
62 [matrix_ renewRows:3 columns:1];
63 EXPECT_EQ(-1, [matrix_ highlightedRow]); 83 EXPECT_EQ(-1, [matrix_ highlightedRow]);
64 84
65 [matrix_ mouseEntered:MouseEventInRow(matrix_, NSMouseMoved, 0)]; 85 [matrix_ mouseEntered:MouseEventInRow(matrix_, NSMouseMoved, 0)];
66 EXPECT_EQ(0, [matrix_ highlightedRow]); 86 EXPECT_EQ(0, [matrix_ highlightedRow]);
67 [matrix_ mouseEntered:MouseEventInRow(matrix_, NSMouseMoved, 2)]; 87 [matrix_ mouseEntered:MouseEventInRow(matrix_, NSMouseMoved, 2)];
68 EXPECT_EQ(2, [matrix_ highlightedRow]); 88 EXPECT_EQ(2, [matrix_ highlightedRow]);
69 89
70 [matrix_ mouseExited:MouseEventInRow(matrix_, NSMouseMoved, 2)]; 90 [matrix_ mouseExited:MouseEventInRow(matrix_, NSMouseMoved, 2)];
71 EXPECT_EQ(-1, [matrix_ highlightedRow]); 91 EXPECT_EQ(-1, [matrix_ highlightedRow]);
72 } 92 }
73 93
74 TEST_F(OmniboxPopupMatrixTest, SelectedRow) { 94 TEST_F(OmniboxPopupMatrixTest, SelectedRow) {
75 [matrix_ renewRows:3 columns:1];
76
77 [NSApp postEvent:MouseEventInRow(matrix_, NSLeftMouseUp, 2) atStart:YES]; 95 [NSApp postEvent:MouseEventInRow(matrix_, NSLeftMouseUp, 2) atStart:YES];
78 [matrix_ mouseDown:MouseEventInRow(matrix_, NSLeftMouseDown, 2)]; 96 [matrix_ mouseDown:MouseEventInRow(matrix_, NSLeftMouseDown, 2)];
79 97
80 EXPECT_EQ(2u, selected_row_); 98 EXPECT_EQ(2u, selected_row_);
81 EXPECT_EQ(2u, clicked_row_); 99 EXPECT_EQ(2u, clicked_row_);
82 EXPECT_EQ(0u, middle_clicked_row_); 100 EXPECT_EQ(0u, middle_clicked_row_);
83 } 101 }
84 102
85 } // namespace 103 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698