Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1099393003: sandbox/mac: Remove basictypes.h include from dispatch_source_mach.h. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 7 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, mdempsky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandbox/mac: Remove basictypes.h include from dispatch_source_mach.h. Tested on Mac with the following command lines: $ rm -rf out/ $ ./build/gyp_chromium $ ninja -C out/Debug sandbox_mac_unittests $ out/Debug/sandbox_mac_unittests BUG=138542 TEST=see above R=jln@chromium.org Committed: https://crrev.com/329ccf6a2872cdeba99b82aca2ae790c549af9e5 Cr-Commit-Position: refs/heads/master@{#327393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M sandbox/linux/services/yama.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/mac/dispatch_source_mach.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
Trivial. PTAL.
5 years, 8 months ago (2015-04-26 15:43:39 UTC) #2
jln (very slow on Chromium)
lgtm
5 years, 7 months ago (2015-04-28 21:59:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099393003/1
5 years, 7 months ago (2015-04-28 22:02:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 23:54:18 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 23:55:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/329ccf6a2872cdeba99b82aca2ae790c549af9e5
Cr-Commit-Position: refs/heads/master@{#327393}

Powered by Google App Engine
This is Rietveld 408576698