Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issue 1099333004: Update {virtual,override} to follow C++11 style in src/utils. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in src/utils. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. The entries were found using the following command line: $ find src/utils -iname "*.h" -o -iname "*.cpp" | xargs pcregrep -M "[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]" The regex was a courtesy of nick@chromium.org BUG=None R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/283b5878e7225a49511cbd3f0fa12603a51319df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M src/utils/SkDeferredCanvas.cpp View 2 chunks +39 lines, -39 lines 0 comments Download
M src/utils/SkEventTracer.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/utils/SkTextBox.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/utils/SkTextureCompressor_Blitter.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099333004/1
5 years, 8 months ago (2015-04-25 19:50:20 UTC) #2
tfarina
5 years, 8 months ago (2015-04-25 19:50:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-25 19:53:49 UTC) #5
mtklein
lgtm
5 years, 8 months ago (2015-04-25 19:59:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099333004/1
5 years, 8 months ago (2015-04-25 19:59:37 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 19:59:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/283b5878e7225a49511cbd3f0fa12603a51319df

Powered by Google App Engine
This is Rietveld 408576698