Issue 1099333002: canonicalize const

Issue 1099333002: canonicalize const (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly

Modified:
5 years, 8 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -143 lines)			Patch
M	lib/runtime/dart/_interceptors.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/runtime/dart/_internal.js	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/runtime/dart/_js_helper.js	View	1 2	7 chunks	+16 lines, -16 lines	0 comments	Download
M	lib/runtime/dart/async.js	View	1	9 chunks	+21 lines, -21 lines	0 comments	Download
M	lib/runtime/dart/convert.js	View	1	12 chunks	+21 lines, -21 lines	0 comments	Download
M	lib/runtime/dart/core.js	View	1 2	4 chunks	+17 lines, -17 lines	0 comments	Download
M	lib/runtime/dart/math.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/runtime/dart/typed_data.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/runtime/dart_runtime.js	View	1 2	13 chunks	+76 lines, -27 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View	1 2	11 chunks	+43 lines, -24 lines	0 comments	Download
M	test/codegen/expect/DeltaBlue.js	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	test/codegen/expect/sunflower/dom.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

Jennifer Messerly

note: I backed out of one optimization until we have a fix for ordering issues

5 years, 8 months ago (2015-04-23 00:17:59 UTC) #2

Jennifer Messerly

Thanks! Merged and landing. btw, this issue is not fixed yet: https://github.com/dart-lang/dev_compiler/issues/153 (Though probably not ...

5 years, 8 months ago (2015-04-23 15:45:47 UTC) #5

Jennifer Messerly

5 years, 8 months ago (2015-04-23 16:12:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:60001) manually as
2614aca3361a76db8b0ca3f5e36872782d8fd70d (presubmit successful).