Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: lib/src/runner/reporter/compact.dart

Issue 1099323002: Make sure a skip message is associated with the correct progress line. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/reporter/compact.dart
diff --git a/lib/src/runner/reporter/compact.dart b/lib/src/runner/reporter/compact.dart
index 034843ae21fa41ad15ce29320ee88c9b7c30747a..2c1e8716095dba0f804e9a3a6cbccb00e188190b 100644
--- a/lib/src/runner/reporter/compact.dart
+++ b/lib/src/runner/reporter/compact.dart
@@ -116,20 +116,21 @@ class CompactReporter {
_passed.add(liveTest);
}
- // Always display the name of the oldest active test, unless testing is
- // finished in which case display the last test to complete.
- if (_active.isEmpty) {
- _progressLine(_description(liveTest));
- } else {
- _progressLine(_description(_active.first));
- }
-
if (liveTest.test.metadata.skip &&
liveTest.test.metadata.skipReason != null) {
+ _progressLine(_description(liveTest));
print('');
print(indent('${_yellow}Skip: ${liveTest.test.metadata.skipReason}'
'$_noColor'));
} else {
+ // Always display the name of the oldest active test, unless testing
+ // is finished in which case display the last test to complete.
+ if (_active.isEmpty) {
+ _progressLine(_description(liveTest));
+ } else {
+ _progressLine(_description(_active.first));
+ }
+
_printedNewline = false;
}
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698