chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 1099313003: Add the IDL and stub implementation for the chrome.autofillPrivate API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 1099313003: Add the IDL and stub implementation for the chrome.autofillPrivate API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update JSON permissions. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/autofill_private/autofill_private_api.h ('K') | « chrome/common/extensions/api/schemas.gypi ('k') | chrome/common/extensions/permissions/chrome_permission_message_rules.cc » ('j') | third_party/closure_compiler/externs/autofill_private.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index 92bb884a0c6a6a227d20623e383984bcbbd99fad..6601fbe0635f2ee3ef559e7a56dc13693c498bb2 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -340,7 +340,12 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

"settingsPrivate",

APIPermissionInfo::kFlagCannotBeOptional,

IDS_EXTENSION_PROMPT_WARNING_SETTINGS_PRIVATE,

- PermissionMessage::kSettingsPrivate},

+ PermissionMessage::kAutofillPrivate},

+ {APIPermission::kAutofillPrivate,

+ "autofillPrivate",

+ APIPermissionInfo::kFlagCannotBeOptional,

not at google - send to devlin 2015/04/23 19:35:52 I wonder why there are so many permissions in this

Kyle Horimoto 2015/04/23 20:23:31 Shouldn't it be non-optional? Without the permissi

+ IDS_EXTENSION_PROMPT_WARNING_AUTOFILL_PRIVATE,

+ PermissionMessage::kAutofillPrivate},

// Full url access permissions.

{APIPermission::kDebugger,