Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: lib/compiler/implementation/enqueue.dart

Issue 10993075: Enable runtime type when it's being hit at resolution. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language_dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/enqueue.dart
===================================================================
--- lib/compiler/implementation/enqueue.dart (revision 12991)
+++ lib/compiler/implementation/enqueue.dart (working copy)
@@ -96,9 +96,10 @@
queue.add(new WorkItem(element, elements, itemCompilationContextCreator()));
// Enable runtime type support if we discover a getter called runtimeType.
- if (!isResolutionQueue &&
- element.isGetter() &&
- element.name == Compiler.RUNTIME_TYPE) {
+ // We have to enable runtime type before hitting the codegen, so
+ // that constructors know whether they need to generate code for
+ // runtime type.
+ if (element.isGetter() && element.name == Compiler.RUNTIME_TYPE) {
compiler.enabledRuntimeType = true;
}
« no previous file with comments | « no previous file | tests/language/language_dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698