Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 10993072: Merge 129814 - REGRESSION(r129186): Pressing enter at the end of a line deletes the line (Closed)

Created:
8 years, 2 months ago by leviw_travelin_and_unemployed
Modified:
8 years, 2 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Merge 129814 - REGRESSION(r129186): Pressing enter at the end of a line deletes the line https://bugs.webkit.org/show_bug.cgi?id=97763 Reviewed by Ryosuke Niwa. r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed this behavior. RenderText::setTextWithOffset is called with a text string identical to the current text. It still dirties lines, then calls setText, which has a check for the case when the strings are the same and returns early and doesn't mark us as needing layout. This change adds the same early bailing logic in setText to setTextWithOffset, but forces setText to work its magic whenever we dirty lines there (and avoid double- checking that the strings are equal). * rendering/RenderText.cpp: (WebCore::RenderText::setTextWithOffset): TBR=leviw@chromium.org Committed: https://trac.webkit.org/changeset/129818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/WebCore/rendering/RenderText.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
leviw_travelin_and_unemployed
8 years, 2 months ago (2012-09-27 23:46:53 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698