Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 10993056: Just because we want to destroy a pointer somewhere other than a destructor doesn't mean we can't u… (Closed)

Created:
8 years, 2 months ago by Peter Kasting
Modified:
8 years, 2 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Just because we want to destroy a pointer somewhere other than a destructor doesn't mean we can't use a scoped_ptr for it. This saves an explicit initializer and makes the code parallel to the ScopedCOMInitializers I'll be adding next. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M content/browser/browser_process_sub_thread.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/browser_process_sub_thread.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Kasting
8 years, 2 months ago (2012-09-27 05:08:51 UTC) #1
Peter Kasting
ping
8 years, 2 months ago (2012-09-29 21:47:19 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
8 years, 2 months ago (2012-10-01 20:11:11 UTC) #3
Peter Kasting
sky, can you OWNERS r+?
8 years, 2 months ago (2012-10-01 20:35:25 UTC) #4
sky
8 years, 2 months ago (2012-10-01 21:15:36 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698