Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: dart/tools/testing/dart/test_runner.dart

Issue 10993048: Always fail if a process failed to launch. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_runner.dart
diff --git a/dart/tools/testing/dart/test_runner.dart b/dart/tools/testing/dart/test_runner.dart
index 6efaa044c3dc4471e6b6892091568f6d2e13a855..3f213909404d3dfaaa9d309ab470e7613a1734de 100644
--- a/dart/tools/testing/dart/test_runner.dart
+++ b/dart/tools/testing/dart/test_runner.dart
@@ -631,6 +631,7 @@ class RunningProcess {
print("Error starting process:");
print(" Command: $command");
print(" Error: $e");
+ testComplete(-1);
};
InputStream stdoutStream = process.stdout;
InputStream stderrStream = process.stderr;
@@ -888,6 +889,10 @@ class BatchRunnerProcess {
print("Error starting process:");
print(" Command: $_executable ${Strings.join(_batchArguments, ' ')}");
print(" Error: $e");
+ // If there is an error starting a batch process, chances are that
+ // it will always fail. So rather than re-trying a 1000+ times, we
+ // exit.
+ exit(1);
};
_process.onStart = then;
}
@@ -1039,6 +1044,8 @@ class ProcessQueue {
print("Error starting process:");
print(" Command: $cmd ${Strings.join(arg, ' ')}");
print(" Error: $e");
+ // TODO(ahe): How to report this as a test failure?
+ exit(1);
};
stdoutStringStream.onLine = () {
var line = stdoutStringStream.readLine();
@@ -1106,6 +1113,8 @@ class ProcessQueue {
print("Error starting process:");
print(" Command: java -jar $file");
print(" Error: $e");
+ // TODO(ahe): How to report this as a test failure?
+ exit(1);
};
// Heads up: there seems to an obscure data race of some form in
// the VM between launching the server process and launching the test
« no previous file with comments | « no previous file | dart/tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698