Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1099303002: Move html_viewer from mojo/services to components. (Closed)

Created:
5 years, 8 months ago by jam
Modified:
5 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, dcheng, abarth-chromium, Aaron Boodman, yzshen+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move html_viewer from mojo/services to components. BUG=479353 TBR=jochen for DEPS Committed: https://crrev.com/81a5661f60738efa7dbbee0a72f2c1e15f6690f9 Cr-Commit-Position: refs/heads/master@{#326369}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -6454 lines) Patch
A + components/html_viewer/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/DEPS View 1 chunk +4 lines, -1 line 0 comments Download
A + components/html_viewer/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/html_viewer/android/android_hooks.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/android/java/org/chromium/html_viewer/Main.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/html_viewer/ax_provider_apptest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/html_viewer/ax_provider_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/ax_provider_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/html_viewer/ax_provider_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/html_viewer/blink_basic_type_converters.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/blink_basic_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/blink_input_events_type_converters.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/blink_input_events_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/blink_platform_impl.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
A + components/html_viewer/blink_platform_impl.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
A + components/html_viewer/blink_resource_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/blink_url_request_type_converters.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/blink_url_request_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/discardable_memory_allocator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/discardable_memory_allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/discardable_memory_allocator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/generate_blink_resource_map.py View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/html_viewer/html_document.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/html_viewer/html_document.cc View 2 chunks +7 lines, -7 lines 0 comments Download
A + components/html_viewer/html_viewer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/html_viewer/html_viewer_version.rc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/html_viewer/mock_web_blob_registry_impl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/mock_web_blob_registry_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/test_blink_platform_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/html_viewer/test_blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/touch_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/touch_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/web_clipboard_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/web_clipboard_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/html_viewer/web_cookie_jar_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/web_cookie_jar_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/web_layer_tree_view_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/web_layer_tree_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/web_media_player_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/web_media_player_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/web_message_port_channel_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/web_message_port_channel_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/web_mime_registry_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/web_mime_registry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/web_notification_manager_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/web_notification_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/web_scheduler_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/web_scheduler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/web_socket_handle_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/web_socket_handle_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/html_viewer/web_storage_namespace_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/web_storage_namespace_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/web_theme_engine_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/html_viewer/web_theme_engine_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/web_thread_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/html_viewer/web_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/html_viewer/web_url_loader_impl.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + components/html_viewer/web_url_loader_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/BUILD.gn View 4 chunks +6 lines, -6 lines 0 comments Download
D mojo/services/html_viewer/BUILD.gn View 1 1 chunk +0 lines, -242 lines 0 comments Download
D mojo/services/html_viewer/DEPS View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/services/html_viewer/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/services/html_viewer/android/android_hooks.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D mojo/services/html_viewer/android/java/org/chromium/html_viewer/Main.java View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/services/html_viewer/ax_provider_apptest.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D mojo/services/html_viewer/ax_provider_impl.h View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/services/html_viewer/ax_provider_impl.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D mojo/services/html_viewer/ax_provider_impl_unittest.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D mojo/services/html_viewer/blink_basic_type_converters.h View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/services/html_viewer/blink_basic_type_converters.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/services/html_viewer/blink_input_events_type_converters.h View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/services/html_viewer/blink_input_events_type_converters.cc View 1 chunk +0 lines, -190 lines 0 comments Download
D mojo/services/html_viewer/blink_platform_impl.h View 1 1 chunk +0 lines, -120 lines 0 comments Download
D mojo/services/html_viewer/blink_platform_impl.cc View 1 1 chunk +0 lines, -323 lines 0 comments Download
D mojo/services/html_viewer/blink_resource_constants.h View 1 chunk +0 lines, -127 lines 0 comments Download
D mojo/services/html_viewer/blink_url_request_type_converters.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/services/html_viewer/blink_url_request_type_converters.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D mojo/services/html_viewer/discardable_memory_allocator.h View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/services/html_viewer/discardable_memory_allocator.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D mojo/services/html_viewer/discardable_memory_allocator_unittest.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D mojo/services/html_viewer/generate_blink_resource_map.py View 1 chunk +0 lines, -146 lines 0 comments Download
D mojo/services/html_viewer/html_document.h View 1 chunk +0 lines, -177 lines 0 comments Download
D mojo/services/html_viewer/html_document.cc View 1 chunk +0 lines, -385 lines 0 comments Download
D mojo/services/html_viewer/html_viewer.cc View 1 chunk +0 lines, -254 lines 0 comments Download
D mojo/services/html_viewer/html_viewer_version.rc View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/services/html_viewer/mock_web_blob_registry_impl.h View 1 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/services/html_viewer/mock_web_blob_registry_impl.cc View 1 1 chunk +0 lines, -121 lines 0 comments Download
D mojo/services/html_viewer/test_blink_platform_impl.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/services/html_viewer/test_blink_platform_impl.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/services/html_viewer/touch_handler.h View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/services/html_viewer/touch_handler.cc View 1 chunk +0 lines, -187 lines 0 comments Download
D mojo/services/html_viewer/web_clipboard_impl.h View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/services/html_viewer/web_clipboard_impl.cc View 1 chunk +0 lines, -207 lines 0 comments Download
D mojo/services/html_viewer/web_cookie_jar_impl.h View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/services/html_viewer/web_cookie_jar_impl.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D mojo/services/html_viewer/web_layer_tree_view_impl.h View 1 chunk +0 lines, -136 lines 0 comments Download
D mojo/services/html_viewer/web_layer_tree_view_impl.cc View 1 chunk +0 lines, -254 lines 0 comments Download
D mojo/services/html_viewer/web_media_player_factory.h View 1 chunk +0 lines, -76 lines 0 comments Download
D mojo/services/html_viewer/web_media_player_factory.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D mojo/services/html_viewer/web_message_port_channel_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/services/html_viewer/web_message_port_channel_impl.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D mojo/services/html_viewer/web_mime_registry_impl.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/services/html_viewer/web_mime_registry_impl.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D mojo/services/html_viewer/web_notification_manager_impl.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/services/html_viewer/web_notification_manager_impl.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/services/html_viewer/web_scheduler_impl.h View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/services/html_viewer/web_scheduler_impl.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D mojo/services/html_viewer/web_socket_handle_impl.h View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/services/html_viewer/web_socket_handle_impl.cc View 1 chunk +0 lines, -219 lines 0 comments Download
D mojo/services/html_viewer/web_storage_namespace_impl.h View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/services/html_viewer/web_storage_namespace_impl.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/services/html_viewer/web_theme_engine_impl.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/services/html_viewer/web_theme_engine_impl.cc View 1 chunk +0 lines, -203 lines 0 comments Download
D mojo/services/html_viewer/web_thread_impl.h View 1 chunk +0 lines, -88 lines 0 comments Download
D mojo/services/html_viewer/web_thread_impl.cc View 1 chunk +0 lines, -187 lines 0 comments Download
D mojo/services/html_viewer/web_url_loader_impl.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
D mojo/services/html_viewer/web_url_loader_impl.cc View 1 1 chunk +0 lines, -305 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Elliot Glaysher
file move lgtm
5 years, 8 months ago (2015-04-22 19:46:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099303002/20001
5 years, 8 months ago (2015-04-22 20:14:08 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-22 20:38:26 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 20:39:56 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81a5661f60738efa7dbbee0a72f2c1e15f6690f9
Cr-Commit-Position: refs/heads/master@{#326369}

Powered by Google App Engine
This is Rietveld 408576698