Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: chrome/browser/bookmarks/DEPS

Issue 10993022: bookmarks: Remove browser_list.h entry from DEPS whitelist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # Bookmarks is being made into a Browser Component, so we have these 2 # Bookmarks is being made into a Browser Component, so we have these
3 # two basic rules followed by temporary exceptions. Please don't 3 # two basic rules followed by temporary exceptions. Please don't
4 # add to the list of exceptions! 4 # add to the list of exceptions!
5 "-chrome/browser", 5 "-chrome/browser",
6 "+chrome/browser/api", 6 "+chrome/browser/api",
7 "+chrome/browser/bookmarks", 7 "+chrome/browser/bookmarks",
8 "+chrome/browser/common", 8 "+chrome/browser/common",
9 9
10 # TODO(kaiwang): Bring this list to zero. 10 # TODO(kaiwang): Bring this list to zero.
(...skipping 16 matching lines...) Expand all
27 "!chrome/browser/importer/importer_data_types.h", 27 "!chrome/browser/importer/importer_data_types.h",
28 "!chrome/browser/importer/importer_host.h", 28 "!chrome/browser/importer/importer_host.h",
29 "!chrome/browser/prefs/incognito_mode_prefs.h", 29 "!chrome/browser/prefs/incognito_mode_prefs.h",
30 "!chrome/browser/prefs/pref_service.h", 30 "!chrome/browser/prefs/pref_service.h",
31 "!chrome/browser/profiles/profile.h", 31 "!chrome/browser/profiles/profile.h",
32 "!chrome/browser/profiles/profile_dependency_manager.h", 32 "!chrome/browser/profiles/profile_dependency_manager.h",
33 "!chrome/browser/profiles/profile_keyed_service.h", 33 "!chrome/browser/profiles/profile_keyed_service.h",
34 "!chrome/browser/profiles/profile_keyed_service_factory.h", 34 "!chrome/browser/profiles/profile_keyed_service_factory.h",
35 "!chrome/browser/ui/bookmarks/bookmark_tab_helper.h", 35 "!chrome/browser/ui/bookmarks/bookmark_tab_helper.h",
36 "!chrome/browser/ui/browser.h", 36 "!chrome/browser/ui/browser.h",
37 "!chrome/browser/ui/browser_list.h",
38 "!chrome/browser/ui/browser_tabstrip.h", 37 "!chrome/browser/ui/browser_tabstrip.h",
39 "!chrome/browser/ui/browser_window.h", 38 "!chrome/browser/ui/browser_window.h",
40 "!chrome/browser/ui/chrome_pages.h", 39 "!chrome/browser/ui/chrome_pages.h",
41 "!chrome/browser/ui/chrome_select_file_policy.h", 40 "!chrome/browser/ui/chrome_select_file_policy.h",
42 "!chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h", 41 "!chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h",
43 "!chrome/browser/ui/gtk/custom_drag.h", 42 "!chrome/browser/ui/gtk/custom_drag.h",
44 "!chrome/browser/ui/simple_message_box.h", 43 "!chrome/browser/ui/simple_message_box.h",
45 "!chrome/browser/ui/tab_contents/tab_contents.h", 44 "!chrome/browser/ui/tab_contents/tab_contents.h",
46 "!chrome/browser/ui/webui/chrome_url_data_manager.h", 45 "!chrome/browser/ui/webui/chrome_url_data_manager.h",
47 "!chrome/browser/view_type_utils.h", 46 "!chrome/browser/view_type_utils.h",
48 # Do not add to the list of temporarily-allowed dependencies above, 47 # Do not add to the list of temporarily-allowed dependencies above,
49 # and please do not introduce more #includes of these files. 48 # and please do not introduce more #includes of these files.
50 ] 49 ]
51 50
52 specific_include_rules = { 51 specific_include_rules = {
53 # TODO(kaiwang): Bring this list to zero. 52 # TODO(kaiwang): Bring this list to zero.
54 # Do not add to the list of temporarily-allowed dependencies below, 53 # Do not add to the list of temporarily-allowed dependencies below,
55 # and please do not introduce more #includes of these files. 54 # and please do not introduce more #includes of these files.
56 '.*_[a-z]*test\.cc': [ 55 '.*_[a-z]*test\.cc': [
57 "!chrome/browser/browser_process.h", 56 "!chrome/browser/browser_process.h",
58 "!chrome/browser/extensions/extension_apitest.h", 57 "!chrome/browser/extensions/extension_apitest.h",
59 "!chrome/browser/history/in_memory_database.h", 58 "!chrome/browser/history/in_memory_database.h",
60 "!chrome/browser/importer/firefox2_importer.h", 59 "!chrome/browser/importer/firefox2_importer.h",
61 "!chrome/browser/profiles/profile_manager.h", 60 "!chrome/browser/profiles/profile_manager.h",
62 "!chrome/browser/ui/browser_commands.h", 61 "!chrome/browser/ui/browser_commands.h",
63 ] 62 ]
64 } 63 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698