Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 1099253002: crazy linker: Fix RELRO sharing with packed relocations. (Closed)

Created:
5 years, 8 months ago by simonb1
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

crazy linker: Fix RELRO sharing with packed relocations. Packed relative relocations do not currently participate in relocation of shared RELRO pages into a service process's load addresses. This undermines RELRO sharing, by reducing the number of swapped RELRO pages (often to zero). Fix by processing packed relative relocations a second time when relocating shared RELRO pages. Also, tidy up and rationalize some duplicated code through use of templates. BUG=385553 Committed: https://crrev.com/733a3f04a20043a7afb55c1a25d14dbaf869b913 Cr-Commit-Position: refs/heads/master@{#326773}

Patch Set 1 #

Patch Set 2 : Rebase to master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -69 lines) Patch
M third_party/android_crazy_linker/README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.h View 2 chunks +58 lines, -20 lines 0 comments Download
M third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp View 12 chunks +159 lines, -45 lines 0 comments Download
M third_party/android_crazy_linker/src/src/crazy_linker_elf_view.h View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
simonb (inactive)
5 years, 8 months ago (2015-04-22 12:52:46 UTC) #2
rmcilroy
lgtm, thanks.
5 years, 8 months ago (2015-04-22 15:46:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099253002/20001
5 years, 8 months ago (2015-04-24 11:32:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 11:55:55 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 11:56:50 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/733a3f04a20043a7afb55c1a25d14dbaf869b913
Cr-Commit-Position: refs/heads/master@{#326773}

Powered by Google App Engine
This is Rietveld 408576698