Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1099203005: Revert of Use standard ICE in Chromoting. (Closed)

Created:
5 years, 8 months ago by horo
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use standard ICE in Chromoting. (patchset #7 id:160001 of https://codereview.chromium.org/1085703003/) Reason for revert: jingle_unittests failure on Mac ASan 64 Tests (1) https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/805 BUG=480107 Original issue's description: > Use standard ICE in Chromoting. > > Previously we were using legacy, non-standard version of ICE. This > change adds ICE version negotiation and enabled standard ICE by default, > when both peers support it. > > BUG=473758 > > Committed: https://crrev.com/4b35571a3085aa960dcf5533fb2277d5dcaaf11f > Cr-Commit-Position: refs/heads/master@{#326435} TBR=rmsousa@chromium.org,wez@chromium.org,dcaiafa@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=473758 Committed: https://crrev.com/372d589d18d9782d8aa2fea2bc6a5d2d37b2ce1b Cr-Commit-Position: refs/heads/master@{#326458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -796 lines) Patch
M remoting/client/jni/chromoting_jni_instance.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 7 chunks +12 lines, -8 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/session_manager_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/content_description.h View 2 chunks +5 lines, -2 lines 0 comments Download
M remoting/protocol/content_description.cc View 5 chunks +30 lines, -26 lines 0 comments Download
M remoting/protocol/fake_connection_to_host.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/fake_connection_to_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/fake_session.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/fake_session.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/jingle_messages.h View 4 chunks +8 lines, -17 lines 0 comments Download
M remoting/protocol/jingle_messages.cc View 8 chunks +45 lines, -209 lines 0 comments Download
M remoting/protocol/jingle_messages_unittest.cc View 3 chunks +16 lines, -107 lines 0 comments Download
M remoting/protocol/jingle_session.h View 6 chunks +8 lines, -17 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 12 chunks +46 lines, -92 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 6 chunks +4 lines, -24 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.h View 2 chunks +1 line, -3 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 12 chunks +16 lines, -65 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 chunk +1 line, -4 lines 0 comments Download
M remoting/protocol/session.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/session_config.h View 5 chunks +40 lines, -35 lines 0 comments Download
M remoting/protocol/session_config.cc View 4 chunks +123 lines, -138 lines 0 comments Download
M remoting/protocol/transport.h View 4 chunks +0 lines, -21 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M remoting/test/test_chromoting_client.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
horo
Created Revert of Use standard ICE in Chromoting.
5 years, 8 months ago (2015-04-23 05:03:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099203005/1
5 years, 8 months ago (2015-04-23 05:03:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 05:04:19 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/372d589d18d9782d8aa2fea2bc6a5d2d37b2ce1b Cr-Commit-Position: refs/heads/master@{#326458}
5 years, 8 months ago (2015-04-23 05:05:14 UTC) #4
Sergey Ulanov
5 years, 8 months ago (2015-04-23 17:23:11 UTC) #5
Message was sent while issue was closed.
On 2015/04/23 05:03:10, horo wrote:
> Created Revert of Use standard ICE in Chromoting.

As explained in the original CL it's not related to jingle_unittests failure.
That test failure looks more like test bot flake, and not related to any code
changes - other test harnesses fail with the same error occasionally on that
bot.

Powered by Google App Engine
This is Rietveld 408576698