Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1099203004: Revert of Protect the emptiness of Array prototype elements with a PropertyCell. (Closed)

Created:
5 years, 8 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Protect the emptiness of Array prototype elements with a PropertyCell. (patchset #7 id:120001 of https://codereview.chromium.org/1092043002/) Reason for revert: MAC GCSTRESS failure on new test. Original issue's description: > Protect the emptiness of Array prototype elements with a PropertyCell. > > Not just emptiness, but also a particular structure. > > BUG=v8:4044 > LOG=N TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4044 Committed: https://crrev.com/15b98a3328b2a2aafb9dfd73287dd7b268e51455 Cr-Commit-Position: refs/heads/master@{#27998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -213 lines) Patch
M src/builtins.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M src/compilation-dependencies.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/hydrogen.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/isolate.cc View 1 chunk +12 lines, -74 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects.cc View 6 chunks +7 lines, -20 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M test/mjsunit/concurrent-initial-prototype-change.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/mjsunit/elide-double-hole-check-12.js View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mvstanton
Created Revert of Protect the emptiness of Array prototype elements with a PropertyCell.
5 years, 8 months ago (2015-04-22 09:56:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099203004/1
5 years, 8 months ago (2015-04-22 09:56:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 09:56:50 UTC) #3
Jakob Kummerow
rubberstamp LGTM
5 years, 8 months ago (2015-04-22 10:28:29 UTC) #4
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1052253003/ by machenbach@chromium.org. ...
5 years, 8 months ago (2015-04-22 10:35:08 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:19:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15b98a3328b2a2aafb9dfd73287dd7b268e51455
Cr-Commit-Position: refs/heads/master@{#27998}

Powered by Google App Engine
This is Rietveld 408576698