Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1099203003: Revert of Revert of Revert of Disable WebGL conformance test on Win8/NVIDIA (Closed)

Created:
5 years, 8 months ago by hendrikw
Modified:
5 years, 8 months ago
Reviewers:
johnme, Zhenyao Mo, ccameron
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #1 id:1 of https://codereview.chromium.org/1082203004/) Reason for revert: The windows test time has been cut in half and shouldn't time out anymore. Original issue's description: > Revert of Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #1 id:1 of https://codereview.chromium.org/1085073002/) > > Reason for revert: > Still very flaky on Win Nvidia: > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webgl_conformance_tests&tests=WebglConformance.conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view > > Original issue's description: > > Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #3 id:40001 of https://codereview.chromium.org/930423002/) > > > > Reason for revert: > > kbr@ doesn't think this is needed anymore, and it might be a cause of us missing real issues. I'll try reverting it, and keep an eye on it. > > > > Original issue's description: > > > Disable WebGL conformance test on Win8/NVIDIA > > > > > > The test: > > > conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view > > > > > > Has been timing out on and off for as long as we have records. > > > > > > BUG=459265 > > > > > > Committed: https://crrev.com/777a126ec7c9fbd50c4f62b27de648e5b306fc7d > > > Cr-Commit-Position: refs/heads/master@{#316872} > > > > TBR=zmo@chromium.org,ccameron@chromium.org > > BUG=459265 > > > > Committed: https://crrev.com/997ea6c612de165623240c058f9e4e89ced7f702 > > Cr-Commit-Position: refs/heads/master@{#325142} > > TBR=zmo@chromium.org,ccameron@chromium.org,hendrikw@chromium.org > BUG=459265 > > Committed: https://crrev.com/c29d5c5f8d7ae90012a3d6bd42218b860cb53558 > Cr-Commit-Position: refs/heads/master@{#325435} TBR=zmo@chromium.org,ccameron@chromium.org,johnme@chromium.org BUG=459265 Committed: https://crrev.com/6e99cf838b13dd8386a5751fb2cc12ac171aadf9 Cr-Commit-Position: refs/heads/master@{#326400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
hendrikw
Created Revert of Revert of Revert of Disable WebGL conformance test on Win8/NVIDIA
5 years, 8 months ago (2015-04-21 23:04:46 UTC) #1
Zhenyao Mo
LGTM
5 years, 8 months ago (2015-04-22 20:48:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099203003/1
5 years, 8 months ago (2015-04-22 20:52:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 23:37:57 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 23:38:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e99cf838b13dd8386a5751fb2cc12ac171aadf9
Cr-Commit-Position: refs/heads/master@{#326400}

Powered by Google App Engine
This is Rietveld 408576698