Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1099143002: Disabled flaky depot_tools tests (Closed)

Created:
5 years, 8 months ago by Sergiy Byelozyorov (Google)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, rmistry1, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/checkout_test.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/gclient_smoketest.py View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
Sergiy Byelozyorov
5 years, 8 months ago (2015-04-21 14:59:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099143002/1
5 years, 8 months ago (2015-04-21 15:02:07 UTC) #4
Adrian Kuegel
LGTM with nit. https://codereview.chromium.org/1099143002/diff/1/tests/checkout_test.py File tests/checkout_test.py (right): https://codereview.chromium.org/1099143002/diff/1/tests/checkout_test.py#newcode457 tests/checkout_test.py:457: @unittest.skip("flaky") nit: same here. https://codereview.chromium.org/1099143002/diff/1/tests/gclient_smoketest.py File ...
5 years, 8 months ago (2015-04-21 15:04:22 UTC) #5
commit-bot: I haz the power
Dry run: Presubmit check for 1099143002-1 failed and returned exit status 1. Running presubmit commit ...
5 years, 8 months ago (2015-04-21 15:05:36 UTC) #7
Sergiy Byelozyorov
Added Philippe for OWNERS
5 years, 8 months ago (2015-04-21 15:12:36 UTC) #9
pgervais
On 2015/04/21 15:12:36, Sergiy Byelozyorov wrote: > Added Philippe for OWNERS lgtm, all the more ...
5 years, 8 months ago (2015-04-21 15:44:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099143002/20001
5 years, 8 months ago (2015-04-21 16:42:47 UTC) #13
commit-bot: I haz the power
Presubmit check for 1099143002-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-21 16:46:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099143002/20001
5 years, 8 months ago (2015-04-27 14:28:16 UTC) #17
commit-bot: I haz the power
Presubmit check for 1099143002-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-27 14:31:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099143002/20001
5 years, 8 months ago (2015-04-27 14:37:10 UTC) #21
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 14:40:17 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295007

Powered by Google App Engine
This is Rietveld 408576698