| 
    
      
  | 
  
 Chromium Code Reviews| 
         Created: 
          5 years, 8 months ago by Sergiy Byelozyorov (Google) Modified: 
          
          
          5 years, 8 months ago CC: 
          
          
          chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, rmistry1, Primiano Tucci (use gerrit) Base URL: 
          
          
          https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref: 
          
          
          refs/heads/master Project: 
          
          tools Visibility: 
          
          
          
        Public.  | 
      
        
  DescriptionDisabled flaky depot_tools tests
R=akuegel@chromium.org,pgervais@chromium.org
BUG=477454
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295007
   
  Patch Set 1 #
      Total comments: 2
      
     
  
  Patch Set 2 : Addressed comments #
 Messages
    Total messages: 22 (10 generated)
     
  
  
 sergiyb@chromium.org changed reviewers: + sergiyb@chromium.org 
 
 The CQ bit was checked by sergiyb@chromium.org to run a CQ dry run 
 Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099143002/1 
 LGTM with nit. https://codereview.chromium.org/1099143002/diff/1/tests/checkout_test.py File tests/checkout_test.py (right): https://codereview.chromium.org/1099143002/diff/1/tests/checkout_test.py#newc... tests/checkout_test.py:457: @unittest.skip("flaky") nit: same here. https://codereview.chromium.org/1099143002/diff/1/tests/gclient_smoketest.py File tests/gclient_smoketest.py (right): https://codereview.chromium.org/1099143002/diff/1/tests/gclient_smoketest.py#... tests/gclient_smoketest.py:1585: @unittest.skip("flaky") nit: use ' instead of " to be consistent with the other part of this file. Same for the others. 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Dry run: Presubmit check for 1099143002-1 failed and returned exit status 1.
Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh
** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    depot_tools/tests/checkout_test.py
    depot_tools/tests/gclient_smoketest.py
Presubmit checks took 204.7s to calculate.
          
 sergiyb@chromium.org changed reviewers: + pgervais@chromium.org 
 Added Philippe for OWNERS 
 On 2015/04/21 15:12:36, Sergiy Byelozyorov wrote: > Added Philippe for OWNERS lgtm, all the more that testing depot_tools against a moving target (blink) is a bad idea. 
 The CQ bit was checked by sergiyb@chromium.org 
 The patchset sent to the CQ was uploaded after l-g-t-m from akuegel@chromium.org Link to the patchset: https://codereview.chromium.org/1099143002/#ps20001 (title: "Addressed comments") 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099143002/20001 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Presubmit check for 1099143002-20001 failed and returned exit status 1.
Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh
** Presubmit ERRORS **
tests/gclient_smoketest.py (119.59s) failed
sss......FFFFF.....
src-git (ERROR)
----------------------------------------
[0:00:00] Started.
[0:00:00] 
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout
--progress git://127.0.0.1:20000/git/repo_1
/tmp/trialyzAoDv/__main__.GClientSmokeBoth.testMultiSolutionsMultiRev/_gclient_src-git_BuoROG'
in '/tmp/trialyzAoDv/__main__.GClientSmokeBoth.testMultiSolutionsMultiRev'
[0:00:00] Cloning into
'/tmp/trialyzAoDv/__main__.GClientSmokeBoth.testMultiSolutionsMultiRev/_gclient_src-git_BuoROG'...
[0:00:00] remote: Counting objects: 10, done.        
[0:00:00] remote: Compressing objects:  25% (1/4)           
[0:00:00] remote: Compressing objects: 100% (4/4)           
[0:00:00] remote: Total 10 (delta 0), reused 0 (delta 0)        
[0:00:00] Receiving objects:  10% (1/10)   
[0:00:00] Receiving objects: 100% (10/10)   
[0:00:00] Checking connectivity... done.
[0:00:00] _____ Conflicting directory found in
/tmp/trialyzAoDv/__main__.GClientSmokeBoth.testMultiSolutionsMultiRev/src-git.
Moving to
/tmp/trialyzAoDv/__main__.GClientSmokeBoth.testMultiSolutionsMultiRev/_bad_scm/src-git5qweI8.
[0:00:00] 
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout
--progress git://127.0.0.1:20000/git/repo_1
/tmp/trialyzAoDv/__main__.GClientSmokeBoth.testMultiSolutionsMultiRev/_gclient_src-git_3FUmMM'
in '/tmp/trialyzAoDv/__main__.GClientSmokeBoth.testMultiSolutionsMultiRev'
[0:00:00] Cloning into
'/tmp/trialyzAoDv/__main__.GClientSmokeBoth.testMultiSolutionsMultiRev/_gclient_src-git_3FUmMM'...
[0:00:00] remote: Counting objects: 10, done.        
[0:00:00] remote: Compressing objects:  25% (1/4)           
[0:00:00] remote: Compressing objects: 100% (4/4)           
[0:00:00] remote: Total 10 (delta 0), reused 0 (delta 0)        
[0:00:00] Receiving objects:  10% (1/10)   
[0:00:00] Receiving objects: 100% (10/10)   
[0:00:00] Checking connectivity... done.
----------------------------------------
Error: Command git checkout --quiet b222d925b9f1132aac83eca3b23695ac82c31f51
returned non-zero exit status 128 in
/tmp/trialyzAoDv/__main__.GClientSmokeBoth.testMultiSolutionsMultiRev/src-git
fatal: reference is not a tree: b222d925b9f1132aac83eca3b23695ac82c31f51
Warnings:
Conflicting directory
/tmp/trialyzAoDv/__main__.GClientSmokeBoth.testMultiSolutionsMultiRev/src-git
moved to
/tmp/trialyzAoDv/__main__.GClientSmokeBoth.testMultiSolutionsMultiRev/_bad_scm/src-git5qweI8.
third_party/foo: svn://127.0.0.1:10000/svn/trunk/third_party/foo@1
src (ERROR)
----------------------------------------
[0:00:00] Started.
[0:00:00] 
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout
--progress git://127.0.0.1:20000/git/repo_5
/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks/_gclient_src_qOtjyV'
in '/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks'
[0:00:00] Cloning into
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks/_gclient_src_qOtjyV'...
[0:00:00] fatal: unable to connect to 127.0.0.1:
[0:00:00] 127.0.0.1[0: 127.0.0.1]: errno=Connection refused
[0:00:00] 
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout
--progress git://127.0.0.1:20000/git/repo_5
/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks/_gclient_src_qOtjyV'
in '/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks'
[0:00:00] Cloning into
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks/_gclient_src_qOtjyV'...
[0:00:00] fatal: unable to connect to 127.0.0.1:
[0:00:00] 127.0.0.1[0: 127.0.0.1]: errno=Connection refused
[0:00:00] 
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout
--progress git://127.0.0.1:20000/git/repo_5
/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks/_gclient_src_qOtjyV'
in '/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks'
[0:00:01] Cloning into
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks/_gclient_src_qOtjyV'...
[0:00:01] fatal: unable to connect to 127.0.0.1:
[0:00:01] 127.0.0.1[0: 127.0.0.1]: errno=Connection refused
[0:00:01] 
________ running 'git -c core.deltaBaseCacheLimit=2g clone --nFFFFo-checkout
--progress git://127.0.0.1:20000/git/repo_5
/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks/_gclient_src_qOtjyV'
in '/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks'
[0:00:03] Cloning into
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks/_gclient_src_qOtjyV'...
[0:00:03] fatal: unable to connect to 127.0.0.1:
[0:00:03] 127.0.0.1[0: 127.0.0.1]: errno=Connection refused
[0:00:03] 
Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient_scm.py", line
909, in _Clone
    self._Run(clone_cmd, options, cwd=self._root_dir, retry=True)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient_scm.py", line
1163, in _Run
    gclient_utils.CheckCallAndFilterAndHeader(cmd, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient_utils.py",
line 293, in CheckCallAndFilterAndHeader
    return CheckCallAndFilter(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient_utils.py",
line 538, in CheckCallAndFilter
    rv, args, kwargs.get('cwd', None), None, None)
CalledProcessError: Command git -c core.deltaBaseCacheLimit=2g clone
--no-checkout --progress git://127.0.0.1:20000/git/repo_5
/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks/_gclient_src_qOtjyV
returned non-zero exit status 128 in
/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks
----------------------------------------
Traceback (most recent call last):
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient.py",
line 2303, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient.py",
line 2289, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 252, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient.py",
line 2046, in CMDsync
    ret = client.RunOnDeps('update', args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient.py",
line 1520, in RunOnDeps
    work_queue.flush(revision_overrides, command, args, options=self._options)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient_utils.py",
line 899, in flush
    self._run_one_task(self.queued.pop(i), args, kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient_utils.py",
line 991, in _run_one_task
    task_item.run(*args, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient.py",
line 832, in run
    file_list)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient_scm.py", line
162, in RunCommand
    return getattr(self, command)(options, args, file_list)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient_scm.py", line
414, in update
    self._Clone(revision, url, options)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient_scm.py", line
917, in _Clone
    if os.listdir(tmp_dir):
OSError: [Errno 2] No such file or directory:
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testPreDepsHooks/_gclient_src_qOtjyV'
src (ERROR)
----------------------------------------
[0:00:00] Started.
[0:00:00] 
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout
--progress git://127.0.0.1:20000/git/repo_1
/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testSync/_gclient_src_xu51Cv' in
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testSync'
[0:00:00] Cloning into
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testSync/_gclient_src_xu51Cv'...
[0:00:00] fatal: unable to connect to 127.0.0.1:
[0:00:00] 127.0.0.1[0: 127.0.0.1]: errno=Connection refused
[0:00:00] 
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout
--progress git://127.0.0.1:20000/git/repo_1
/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testSync/_gclient_src_xu51Cv' in
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testSync'
[0:00:00] Cloning into
'/tmp/trialyzAoDv/__main__.GClientFSmokeGIT.testSync/_gclient_src_xu51Cv'...
[0:00:00] fatal: unable to connect to 127.0.0.1:
[0:00:00] 127.0.0.1[0: 127.0.0.1]: errno=Connection refused
[0:00:00] 
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout
--progress git://127.0.0.1:20000/git/repo_1
/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testSync/_gclient_src_xu51Cv' in
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testSync'
[0:00:01] Cloning into
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testSync/_gclient_src_xu51Cv'...
[0:00:01] fatal: unable to connect to 127.0.0.1:
[0:00:01] 127.0.0.1[0: 127.0.0.1]: errno=Connection refused
[0:00:01] 
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout
--progress git://127.0.0.1:20000/git/repo_1
/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testSync/_gclient_src_xu51Cv' in
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testSync'
[0:00:03] Cloning into
'/tmp/trialyzAoDv/__main__.GClientSmokeGIT.testSync/_gclient_src_xu51Cv'...
[0:00:03] fatal: unable to connect to 127.0.0.1:
[0:00:03] 127.0.0.1[0: 127.0.0.1]: errno=Connection refused
[0:00:03] 
Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/gclient_scm.py", line
909, in _Clone
    self._Run(clone_…
(message too large)
          
 The CQ bit was checked by sergiyb@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099143002/20001 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Presubmit check for 1099143002-20001 failed and returned exit status 1.
Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh
** Presubmit ERRORS **
tests/checkout_test.py (39.70s) failed
Cloning into '/tmp/trialcTcmpd/__main__.GitCheckout.testAll/foo'...
done.
Switched to branch 'master'
Already on 'master'
.sECloning into '/tmp/trialcTcmpd/__main__.GitCheckout.testProcess/foo'...
done.
....................
======================================================================
ERROR: testMove (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 347, in setUp
    self.enabled = self.FAKE_REPOS.set_up_git()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 359, in set_up_git
    self.set_up()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 211, in set_up
    self.cleanup_dirt()
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 229, in cleanup_dirt
    if not self.tear_down_git():
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 276, in tear_down_git
    wait_for_port_to_free(self.host, self.git_port)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 161, in wait_for_port_to_free
    assert False, '%d is still bound' % port
AssertionError: 20000 is still bound
----------------------------------------------------------------------
Ran 23 tests in 39.417s
FAILED (errors=1, skipped=1)
Presubmit checks took 191.4s to calculate.
          
 The CQ bit was checked by sergiyb@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099143002/20001 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295007  | 
    |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
