Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 1099123002: Split default and user-supplied event tracers. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Split default and user-supplied event tracers. Chrome's got a test scenario where setting the user-supplied tracer is racing with a concurrent use of the default tracer. BUG=chromium:437044 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/59bcfaed660369da2a08fc3ad1ec2799b646f3e1

Patch Set 1 #

Patch Set 2 : Just leak the default tracer if we overrode it. #

Patch Set 3 : pointers #

Patch Set 4 : tweaks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M include/utils/SkEventTracer.h View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M src/utils/SkEventTracer.cpp View 1 2 3 2 chunks +17 lines, -17 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
mtklein_C
5 years, 8 months ago (2015-04-21 14:30:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099123002/60001
5 years, 8 months ago (2015-04-21 14:35:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-21 14:44:56 UTC) #6
humper
On 2015/04/21 14:44:56, I haz the power (commit-bot) wrote: > Dry run: This issue passed ...
5 years, 8 months ago (2015-04-21 15:39:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099123002/60001
5 years, 8 months ago (2015-04-21 15:47:44 UTC) #9
Alexander Potapenko
https://codereview.chromium.org/1099123002/diff/60001/src/utils/SkEventTracer.cpp File src/utils/SkEventTracer.cpp (right): https://codereview.chromium.org/1099123002/diff/60001/src/utils/SkEventTracer.cpp#newcode55 src/utils/SkEventTracer.cpp:55: if (SkEventTracer* tracer = sk_atomic_load(&gUserTracer, sk_memory_order_relaxed)) { Since you're ...
5 years, 8 months ago (2015-04-21 15:55:38 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 16:38:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/59bcfaed660369da2a08fc3ad1ec2799b646f3e1

Powered by Google App Engine
This is Rietveld 408576698