Miscellaneous tiny cleanups done while converting files to use ScopedCOMInitializer, pulled out sep…

chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <oleacc.h>
 
 #include "base/utf_string_conversions.h"
 #include "base/win/scoped_comptr.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
@@ skipping 13 matching lines @@
 #include "ui/views/widget/widget.h"
 
 namespace {
 
 VARIANT id_self = {VT_I4, CHILDID_SELF};
 
 }  // namespace
 
 class BrowserViewsAccessibilityTest : public InProcessBrowserTest {
  public:
-  BrowserViewsAccessibilityTest() {
-    ui::win::CreateATLModuleIfNeeded();
-    ::CoInitialize(NULL);
-  }
+  BrowserViewsAccessibilityTest();
+  ~BrowserViewsAccessibilityTest();
 
-  ~BrowserViewsAccessibilityTest() {
-    ::CoUninitialize();
-  }
+  // Retrieves an instance of BrowserWindowTesting.
+  BrowserWindowTesting* GetBrowserWindowTesting();
 
-  // Retrieves an instance of BrowserWindowTesting
-  BrowserWindowTesting* GetBrowserWindowTesting() {
-    BrowserWindow* browser_window = browser()->window();
-
-    if (!browser_window)
-      return NULL;
-
-    return browser_window->GetBrowserWindowTesting();
-  }
-
-  // Retrieve an instance of BrowserView
-  BrowserView* GetBrowserView() {
-    return BrowserView::GetBrowserViewForBrowser(browser());
-  }
+  // Retrieve an instance of BrowserView.
+  BrowserView* GetBrowserView();
 
   // Retrieves and initializes an instance of ToolbarView.
-  ToolbarView* GetToolbarView() {
-    BrowserWindowTesting* browser_window_testing = GetBrowserWindowTesting();
-
-    if (!browser_window_testing)
-      return NULL;
-
-    return browser_window_testing->GetToolbarView();
-  }
+  ToolbarView* GetToolbarView();
 
   // Retrieves and initializes an instance of BookmarkBarView.
-  BookmarkBarView* GetBookmarkBarView() {
-    BrowserWindowTesting* browser_window_testing = GetBrowserWindowTesting();
-
-    if (!browser_window_testing)
-      return NULL;
-
-    return browser_window_testing->GetBookmarkBarView();
-  }
+  BookmarkBarView* GetBookmarkBarView();
 
   // Retrieves and verifies the accessibility object for the given View.
-  void TestViewAccessibilityObject(views::View* view, std::wstring name,
-                                   int32 role) {
-    ASSERT_TRUE(NULL != view);
-
-    TestAccessibilityInfo(view->GetNativeViewAccessible(), name, role);
-  }
-
+  void TestViewAccessibilityObject(views::View* view,
+                                   std::wstring name,
+                                   int32 role);
 
   // Verifies MSAA Name and Role properties of the given IAccessible.
-  void TestAccessibilityInfo(IAccessible* acc_obj, std::wstring name,
-                             int32 role) {
-    // Verify MSAA Name property.
-    BSTR acc_name;
+  void TestAccessibilityInfo(IAccessible* acc_obj,
+                             std::wstring name,
+                             int32 role);
+};
 
-    HRESULT hr = acc_obj->get_accName(id_self, &acc_name);
-    ASSERT_EQ(S_OK, hr);
-    EXPECT_STREQ(acc_name, name.c_str());
+BrowserViewsAccessibilityTest::BrowserViewsAccessibilityTest() {
+  ui::win::CreateATLModuleIfNeeded();
+  ::CoInitialize(NULL);

[dmazzoni, 2012/09/27 06:22:39]

Should this be using ScopedComInitializer as long as you're refactoring?

[Peter Kasting, 2012/09/27 06:25:15]

This is precisely why I said: "...done while converting files to use
ScopedCOMInitializer, pulled out separately to make review easier." in my CL
description.

Because I'll be making that change separately.

+}
 
-    // Verify MSAA Role property.
-    VARIANT acc_role;
-    ::VariantInit(&acc_role);
+BrowserViewsAccessibilityTest~BrowserViewsAccessibilityTest() {

[dmazzoni, 2012/09/27 06:22:39]

Typo here?

[Peter Kasting, 2012/09/27 06:25:15]

Indeed.  Good catch.

+  ::CoUninitialize();
+}
 
-    hr = acc_obj->get_accRole(id_self, &acc_role);
-    ASSERT_EQ(S_OK, hr);
-    EXPECT_EQ(VT_I4, acc_role.vt);
-    EXPECT_EQ(role, acc_role.lVal);
+BrowserWindowTesting* BrowserViewsAccessibilityTest::GetBrowserWindowTesting() {
+  BrowserWindow* browser_window = browser()->window();
+  return browser_window ? browser_window->GetBrowserWindowTesting() : NULL;
+}
 
-    ::VariantClear(&acc_role);
-    ::SysFreeString(acc_name);
-  }
-};
+BrowserView* BrowserViewsAccessibilityTest::GetBrowserView() {
+  return BrowserView::GetBrowserViewForBrowser(browser());
+}
+
+ToolbarView* BrowserViewsAccessibilityTest::GetToolbarView() {
+  BrowserWindowTesting* browser_window_testing = GetBrowserWindowTesting();
+  return browser_window_testing ?
+      browser_window_testing->GetToolbarView() : NULL;
+}
+
+BookmarkBarView* BrowserViewsAccessibilityTest::GetBookmarkBarView() {
+  BrowserWindowTesting* browser_window_testing = GetBrowserWindowTesting();
+  return browser_window_testing ?
+      browser_window_testing->GetBookmarkBarView() : NULL;
+}
+
+void BrowserViewsAccessibilityTest::TestViewAccessibilityObject(
+    views::View* view,
+    std::wstring name,
+    int32 role) {
+  ASSERT_TRUE(view != NULL);
+  TestAccessibilityInfo(view->GetNativeViewAccessible(), name, role);
+}
+
+void BrowserViewsAccessibilityTest::TestAccessibilityInfo(IAccessible* acc_obj,
+                                                          std::wstring name,
+                                                          int32 role) {
+  // Verify MSAA Name property.
+  BSTR acc_name;
+
+  HRESULT hr = acc_obj->get_accName(id_self, &acc_name);
+  ASSERT_EQ(S_OK, hr);
+  EXPECT_STREQ(acc_name, name.c_str());
+
+  // Verify MSAA Role property.
+  VARIANT acc_role;
+  ::VariantInit(&acc_role);
+
+  hr = acc_obj->get_accRole(id_self, &acc_role);
+  ASSERT_EQ(S_OK, hr);
+  EXPECT_EQ(VT_I4, acc_role.vt);
+  EXPECT_EQ(role, acc_role.lVal);
+
+  ::VariantClear(&acc_role);
+  ::SysFreeString(acc_name);
+}
 
 // Retrieve accessibility object for main window and verify accessibility info.
 IN_PROC_BROWSER_TEST_F(BrowserViewsAccessibilityTest,
                        TestChromeWindowAccObj) {
   BrowserWindow* browser_window = browser()->window();
   ASSERT_TRUE(NULL != browser_window);
 
   HWND hwnd = browser_window->GetNativeWindow();
   ASSERT_TRUE(NULL != hwnd);
 
@@ skipping 129 matching lines @@
 }
 
 // http://crbug.com/104132
 IN_PROC_BROWSER_TEST_F(BrowserViewsAccessibilityTest,
                        DISABLED_TestBookmarkBarViewAccObj) {
   TestViewAccessibilityObject(
       GetBookmarkBarView(),
       UTF16ToWide(l10n_util::GetStringUTF16(IDS_ACCNAME_BOOKMARKS)),
       ROLE_SYSTEM_TOOLBAR);
 }