Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 10991044: Revert 158830 - Revert 156678 - Native messaging now uses the MessageService back-end. (Closed)

Created:
8 years, 2 months ago by Isaac (away)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Revert 158830 - Revert 156678 - Native messaging now uses the MessageService back-end. Reason: Regression in a ChromeOS extension causing it to continue running after unloading. BUG=142915 Review URL: https://codereview.chromium.org/10818013 TBR=eaugusti@chromium.org TBR=mpcomplete@chromium.org TBR=mmoss, rouslan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -141 lines) Patch
A + chrome/browser/extensions/api/messaging/extension_message_port.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/messaging/extension_message_port.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 16 chunks +183 lines, -146 lines 0 comments Download
A + chrome/browser/extensions/api/messaging/native_message_port.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/messaging/native_message_port.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/messaging/native_message_process_host.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/messaging/native_message_process_host.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/messaging/native_message_process_host_posix.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/messaging/native_message_process_host_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/messaging/native_messaging_apitest_posix.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/messaging/native_process_launcher.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/messaging/native_process_launcher_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/message_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension.json View 2 chunks +62 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/extension_custom_bindings.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/extension_custom_bindings.cc View 3 chunks +34 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/extension_custom_bindings.js View 5 chunks +43 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/miscellaneous_bindings.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Isaac (away)
8 years, 2 months ago (2012-09-26 18:30:52 UTC) #1
Isaac (away)
This caused widespread compile failures on the tree (i.e. http://goo.gl/OrILM) Error below: In file included ...
8 years, 2 months ago (2012-09-26 18:38:58 UTC) #2
Isaac (away)
8 years, 2 months ago (2012-09-26 18:39:51 UTC) #3
err, I mean 158830 caused errors.  This revert was clean.

Powered by Google App Engine
This is Rietveld 408576698