Issue 10991038: content-shell: Allow using the mouse the generate touch-events in linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10991038: content-shell: Allow using the mouse the generate touch-events in linux. (Closed)

Created:
8 years, 2 months ago by sadrul

Modified:
8 years, 2 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

content-shell: Allow using the mouse the generate touch-events in linux. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158871

Patch Set 2 : . #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	content/shell/shell_browser_main_parts.cc	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm https://chromiumcodereview.appspot.com/10991038/diff/1/content/shell/shell_browser_main_parts.cc File content/shell/shell_browser_main_parts.cc (right): https://chromiumcodereview.appspot.com/10991038/diff/1/content/shell/shell_browser_main_parts.cc#newcode86 content/shell/shell_browser_main_parts.cc:86: #if defined(OS_LINUX) && defined(USE_AURA) web_contents_impl uses defined(USE_AURA) && ...

8 years, 2 months ago (2012-09-26 18:41:57 UTC) #2

sadrul

8 years, 2 months ago (2012-09-26 19:45:54 UTC) #3

http://codereview.chromium.org/10991038/diff/1/content/shell/shell_browser_ma...
File content/shell/shell_browser_main_parts.cc (right):

http://codereview.chromium.org/10991038/diff/1/content/shell/shell_browser_ma...
content/shell/shell_browser_main_parts.cc:86: #if defined(OS_LINUX) &&
defined(USE_AURA)
On 2012/09/26 18:41:57, jochen wrote:
> web_contents_impl uses defined(USE_AURA) && defined(USE_X11). I think we
should
> do the same here

Done.

Expand Messages | Collapse Messages

Issue 10991038: content-shell: Allow using the mouse the generate touch-events in linux. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages