Order the parameters of a function at the definition site.

lib/compiler/implementation/ssa/builder.dart

Index: lib/compiler/implementation/ssa/builder.dart
===================================================================
--- lib/compiler/implementation/ssa/builder.dart	(revision 12897)
+++ lib/compiler/implementation/ssa/builder.dart	(working copy)
@@ -212,7 +212,7 @@
                                              defaultValueTypes);
         if (!parameterTypes.allUnknown) {
           int i = 0;
-          signature.forEachParameter((Element param) {
+          signature.orderedForEachParameter((Element param) {
             builder.parameters[param].guaranteedType = parameterTypes[i++];
           });
         }
@@ -365,7 +365,7 @@
     closureData = compiler.closureToClassMapper.computeClosureToClassMapping(
             node, builder.elements);
     FunctionSignature signature = function.computeSignature(compiler);
-    signature.forEachParameter((Element element) {
+    signature.orderedForEachParameter((Element element) {
       HInstruction parameter = new HParameterValue(element);
       builder.add(parameter);
       builder.parameters[element] = parameter;
@@ -1014,7 +1014,7 @@
     assert(elements !== null);
     FunctionSignature signature = function.computeSignature(compiler);
     int index = 0;
-    signature.forEachParameter((Element parameter) {
+    signature.orderedForEachParameter((Element parameter) {
       HInstruction argument = compiledArguments[index++];
       localsHandler.updateLocal(parameter, argument);
       potentiallyCheckType(argument, parameter);
@@ -1117,7 +1117,7 @@
 
       int index = 0;
       FunctionSignature params = constructor.computeSignature(compiler);
-      params.forEachParameter((Element parameter) {
+      params.orderedForEachParameter((Element parameter) {
         HInstruction argument = compiledArguments[index++];
         localsHandler.updateLocal(parameter, argument);
         // Don't forget to update the field, if the parameter is of the
@@ -1269,7 +1269,7 @@
 
     // Compile field-parameters such as [:this.x:].
     FunctionSignature params = functionElement.computeSignature(compiler);
-    params.forEachParameter((Element element) {
+    params.orderedForEachParameter((Element element) {
       if (element.kind == ElementKind.FIELD_PARAMETER) {
         // If the [element] is a field-parameter then
         // initialize the field element with its value.
@@ -1317,7 +1317,7 @@
       bodyCallInputs.add(newObject);
       FunctionSignature functionSignature = body.computeSignature(compiler);
       int arity = functionSignature.parameterCount;
-      functionSignature.forEachParameter((parameter) {
+      functionSignature.orderedForEachParameter((parameter) {
         bodyCallInputs.add(localsHandler.readLocal(parameter));
       });
       // TODO(ahe): The constructor name is statically resolved. See
@@ -1399,7 +1399,7 @@
     open(block);
 
     FunctionSignature params = functionElement.computeSignature(compiler);
-    params.forEachParameter((Element element) {
+    params.orderedForEachParameter((Element element) {
       if (elements.isParameterChecked(element)) {
         addParameterCheckInstruction(element);
       }
@@ -1409,7 +1409,7 @@
     // because that is where the type guards will also be inserted.
     // This way we ensure that a type guard will dominate the type
     // check.
-    params.forEachParameter((Element element) {
+    params.orderedForEachParameter((Element element) {
       HInstruction newParameter = potentiallyCheckType(
           localsHandler.directLocals[element], element);
       localsHandler.directLocals[element] = newParameter;