lib/compiler/implementation/js_backend/emitter.dart - Issue 10991034: Order the parameters of a function at the definition site.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/js_backend/emitter.dart

Issue 10991034: Order the parameters of a function at the definition site. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/elements/elements.dart ('K') | « lib/compiler/implementation/elements/elements.dart ('k') | lib/compiler/implementation/js_backend/namer.dart » ('j') | lib/compiler/implementation/js_backend/namer.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/js_backend/emitter.dart

===================================================================

--- lib/compiler/implementation/js_backend/emitter.dart (revision 12897)

+++ lib/compiler/implementation/js_backend/emitter.dart (working copy)

@@ -388,7 +388,7 @@

TreeElements elements =

compiler.enqueuer.resolution.getCachedElements(member);

- parameters.forEachParameter((Element element) {

+ parameters.orderedForEachParameter((Element element) {

String jsName = JsNames.getValid(element.name.slowToString());

if (count < positionalArgumentCount) {

parametersBuffer[count] = jsName;