Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1099103003: Compact weak fixed arrays before serializing. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Compact weak fixed arrays before serializing. R=ulan@chromium.org BUG=v8:4050 LOG=N Committed: https://crrev.com/7b1b964362adeb8a04e558442e5eec8b9d62f462 Cr-Commit-Position: refs/heads/master@{#27988}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename variables #

Patch Set 3 : fi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/objects.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Yang
5 years, 8 months ago (2015-04-21 13:20:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099103003/1
5 years, 8 months ago (2015-04-21 13:26:10 UTC) #3
ulan
lgtm https://codereview.chromium.org/1099103003/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1099103003/diff/1/src/objects.cc#newcode8300 src/objects.cc:8300: int w = 0; s/w/new_length/
5 years, 8 months ago (2015-04-21 13:42:10 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4996)
5 years, 8 months ago (2015-04-21 13:44:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099103003/20001
5 years, 8 months ago (2015-04-21 14:29:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/5006)
5 years, 8 months ago (2015-04-21 15:03:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099103003/40001
5 years, 8 months ago (2015-04-22 07:05:23 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-22 07:40:10 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:18:56 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7b1b964362adeb8a04e558442e5eec8b9d62f462
Cr-Commit-Position: refs/heads/master@{#27988}

Powered by Google App Engine
This is Rietveld 408576698