Issue 1099093005: Subzero: Improve "make check-unit" execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1099093005: Subzero: Improve "make check-unit" execution. (Closed)

Created:
5 years, 8 months ago by Jim Stichnoth

Modified:
5 years, 8 months ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Improve "make check-unit" execution. If you switch between "cmake" and "autoconf" toolchain builds, and neglect to clean out pnacl_newlib_raw/ in between, the wrong libgtest and libgtest_main may get pulled in for the autoconf build, leading to an assertion failure in "make check-unit". This tweak fixes that problem by rejiggering the lib search path. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e7e9b02408c4ffd62a05e1bd963a5c92487a51ea

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Makefile.standalone	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

5 years, 8 months ago (2015-04-21 22:05:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e7e9b02408c4ffd62a05e1bd963a5c92487a51ea (presubmit successful).