Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1099033005: Revert of Telemetry: Re-enable ServiceWorkerPerfTest, increase timeout for VideoRecorder.IsStarted (Closed)

Created:
5 years, 8 months ago by Kunihiko Sakamoto
Modified:
5 years, 8 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org, serviceworker-reviews, oystein (OOO til 10th of July), eakuefner, Yufeng Shen (Slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Telemetry: Re-enable ServiceWorkerPerfTest, increase timeout for VideoRecorder.IsStarted (patchset #1 id:1 of https://codereview.chromium.org/1093923004/) Reason for revert: It still times out: http://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf/builds/615/steps/service_worker.service_worker/logs/stdio Original issue's description: > Telemetry: Re-enable ServiceWorkerPerfTest, increase timeout for VideoRecorder.IsStarted > > ServiceWorkerPerfTest was failing on Android One, due to timeouts of > VideoRecorder.IsStarted(). This patch attempts to fix this by increasing > the timeout from 5 seconds to 10 seconds, and re-enable the test. > > BUG=469841 > TEST=tools/perf/run_benchmark --browser=trybot-all-android service_worker.service_worker > > Committed: https://crrev.com/42ce01867659573b37b46df12a3db18ba26674b9 > Cr-Commit-Position: refs/heads/master@{#326820} TBR=sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=469841 Committed: https://crrev.com/a135a4bf44b38dfe742303c97281f1ba0e092b44 Cr-Commit-Position: refs/heads/master@{#327005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/perf/benchmarks/service_worker.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Kunihiko Sakamoto
Created Revert of Telemetry: Re-enable ServiceWorkerPerfTest, increase timeout for VideoRecorder.IsStarted
5 years, 8 months ago (2015-04-27 06:41:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099033005/1
5 years, 8 months ago (2015-04-27 06:41:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 06:41:42 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 06:42:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a135a4bf44b38dfe742303c97281f1ba0e092b44
Cr-Commit-Position: refs/heads/master@{#327005}

Powered by Google App Engine
This is Rietveld 408576698