Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5801)

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 1099033004: Add a text/password field count metric for empty username forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Checking for no passwords. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_form_conversion_utils.cc
diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc
index 44fc3230804714760d65c1d24e5e0a4becc683f2..a38a182253007a3772ebfa17edffb85abc0b0d10 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils.cc
+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc
@@ -8,6 +8,7 @@
#include "base/lazy_instance.h"
#include "base/memory/scoped_ptr.h"
+#include "base/metrics/histogram.h"
Ilya Sherman 2015/05/13 00:17:19 nit: Please include histogram_macros instead.
msramek 2015/05/13 15:51:34 Done.
#include "base/strings/string_util.h"
#include "components/autofill/content/renderer/form_autofill_util.h"
#include "components/autofill/core/common/form_data_predictions.h"
@@ -404,6 +405,14 @@ void GetPasswordForm(
password_form->new_password_marked_by_site = true;
}
+ if (username_element.isNull()) {
+ // To get a better idea on how password forms without a username field
+ // look like, report the total number of text and password fields.
+ UMA_HISTOGRAM_COUNTS_100(
+ "PasswordManager.EmptyUsernames.TextAndPasswordFieldCount",
+ layout_sequence.size());
+ }
+
password_form->scheme = PasswordForm::SCHEME_HTML;
password_form->ssl_valid = false;
password_form->preferred = false;
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698