Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1099023005: Implement support for <audio> in ChromeVox Next. (Closed)

Created:
5 years, 8 months ago by David Tseng
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement support for <audio> in ChromeVox Next. - pick up the decsription attribute in buttons - add the help attribute in sliders TEST=chromevox_tests --gtest_filter=OutputE2ETest.Audio Committed: https://crrev.com/8be28877e6d5072d77dab0488e4198abd00c482e Cr-Commit-Position: refs/heads/master@{#326841}

Patch Set 1 #

Patch Set 2 : Make sliders atomic. #

Total comments: 1

Patch Set 3 : Rebased on presubmit fix. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 3 3 chunks +17 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
David Tseng
5 years, 8 months ago (2015-04-22 23:14:52 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/1099023005/diff/20001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js (right): https://codereview.chromium.org/1099023005/diff/20001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js#newcode166 chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:166: speak: '$name $value $description $role', As suggested in ...
5 years, 8 months ago (2015-04-24 13:41:08 UTC) #4
David Tseng
On 2015/04/24 13:41:08, dmazzoni wrote: > lgtm > > https://codereview.chromium.org/1099023005/diff/20001/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js > File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js > (right): ...
5 years, 8 months ago (2015-04-24 16:13:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099023005/60001
5 years, 8 months ago (2015-04-24 17:42:02 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-24 18:14:40 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 18:16:15 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8be28877e6d5072d77dab0488e4198abd00c482e
Cr-Commit-Position: refs/heads/master@{#326841}

Powered by Google App Engine
This is Rietveld 408576698