Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1099023003: Ask for NVPR only when we expect it to be available. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Ask for NVPR only when we expect it to be available. BUG=skia: Committed: https://skia.googlesource.com/skia/+/fca5c88873cbf30f756bcb57e28df62f56c26d85

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -8 lines) Patch
M tools/dm_flags.json View 7 chunks +152 lines, -6 lines 2 comments Download
M tools/dm_flags.py View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein
5 years, 8 months ago (2015-04-21 17:22:25 UTC) #2
borenet
https://codereview.chromium.org/1099023003/diff/1/tools/dm_flags.json File tools/dm_flags.json (right): https://codereview.chromium.org/1099023003/diff/1/tools/dm_flags.json#newcode159 tools/dm_flags.json:159: "msaa4", Does Tegra3 support nvprmsaa4? https://codereview.chromium.org/1099023003/diff/1/tools/dm_flags.json#newcode609 tools/dm_flags.json:609: "msaa4", Does ...
5 years, 8 months ago (2015-04-21 17:24:17 UTC) #3
mtklein
On 2015/04/21 17:24:17, borenet wrote: > https://codereview.chromium.org/1099023003/diff/1/tools/dm_flags.json > File tools/dm_flags.json (right): > > https://codereview.chromium.org/1099023003/diff/1/tools/dm_flags.json#newcode159 > ...
5 years, 8 months ago (2015-04-21 17:26:18 UTC) #4
borenet
On 2015/04/21 17:26:18, mtklein wrote: > On 2015/04/21 17:24:17, borenet wrote: > > https://codereview.chromium.org/1099023003/diff/1/tools/dm_flags.json > ...
5 years, 8 months ago (2015-04-21 17:27:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099023003/1
5 years, 8 months ago (2015-04-21 17:28:36 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 17:34:51 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fca5c88873cbf30f756bcb57e28df62f56c26d85

Powered by Google App Engine
This is Rietveld 408576698