Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 10990121: We're removing the sharedWorkerRepository() function from WebKit (Closed)

Created:
8 years, 2 months ago by pilgrim_google
Modified:
8 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, pam+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

We're removing the sharedWorkerRepository() function from WebKit and replacing it with a setSharedWorkerRepository() function that is called once at initialization. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172197

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -32 lines) Patch
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/ppapi_plugin/ppapi_webkitplatformsupport_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_webkitplatformsupport_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
darin (slow to review)
LGTM
8 years ago (2012-12-10 20:38:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/10990121/13002
8 years ago (2012-12-10 20:38:23 UTC) #2
commit-bot: I haz the power
8 years ago (2012-12-11 00:10:01 UTC) #3
Message was sent while issue was closed.
Change committed as 172197

Powered by Google App Engine
This is Rietveld 408576698