Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 10990070: Not set -m32 flag when compiling with Android ARM compiler. (Closed)

Created:
8 years, 2 months ago by michaelbai
Modified:
8 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
http://git.chromium.org/external/v8.git@master
Visibility:
Public.

Description

Not set -m32 flag when compiling with Android ARM compiler. We are removing CXX_target environment variables and only use the make_global_settings to select compiler in chromium Android. BUG=143889 Committed: https://code.google.com/p/v8/source/detail?r=12630

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +6 lines, -2 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
michaelbai
As we discussed, I created this CL.
8 years, 2 months ago (2012-09-26 20:56:34 UTC) #1
Jakob Kummerow
LGTM with the comments below. I'll fix both and land this. http://codereview.chromium.org/10990070/diff/1/build/common.gypi File build/common.gypi (right): ...
8 years, 2 months ago (2012-09-28 14:38:33 UTC) #2
michaelbai
8 years, 2 months ago (2012-09-28 16:38:06 UTC) #3
Thanks

Powered by Google App Engine
This is Rietveld 408576698