Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: runtime/vm/intrinsifier_ia32.cc

Issue 10990055: Hide VM-only coreimpl List implementation types. These should not be (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix on x64 as well. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // The intrinsic code below is executed before a method has built its frame. 5 // The intrinsic code below is executed before a method has built its frame.
6 // The return address is on the stack and the arguments below it. 6 // The return address is on the stack and the arguments below it.
7 // Registers EDX (arguments descriptor) and ECX (function) must be preserved. 7 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
8 // Each intrinsification method returns true if the corresponding 8 // Each intrinsification method returns true if the corresponding
9 // Dart method was intrinsified. 9 // Dart method was intrinsified.
10 10
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 return false; 167 return false;
168 } 168 }
169 169
170 170
171 bool Intrinsifier::ImmutableArray_getIndexed(Assembler* assembler) { 171 bool Intrinsifier::ImmutableArray_getIndexed(Assembler* assembler) {
172 return Array_getIndexed(assembler); 172 return Array_getIndexed(assembler);
173 } 173 }
174 174
175 175
176 static intptr_t ComputeObjectArrayTypeArgumentsOffset() { 176 static intptr_t ComputeObjectArrayTypeArgumentsOffset() {
177 const String& class_name = String::Handle(Symbols::New("ObjectArray")); 177 const String& class_name = String::Handle(Symbols::New("_ObjectArray"));
178 const Class& cls = Class::Handle( 178 const Class& cls = Class::Handle(
179 Library::Handle(Library::CoreImplLibrary()).LookupClass(class_name)); 179 Library::Handle(Library::CoreImplLibrary()).LookupClass(class_name));
180 ASSERT(!cls.IsNull()); 180 ASSERT(!cls.IsNull());
181 ASSERT(cls.HasTypeArguments()); 181 ASSERT(cls.HasTypeArguments());
182 ASSERT(cls.NumTypeArguments() == 1); 182 ASSERT(cls.NumTypeArguments() == 1);
183 const intptr_t field_offset = cls.type_arguments_instance_field_offset(); 183 const intptr_t field_offset = cls.type_arguments_instance_field_offset();
184 ASSERT(field_offset != Class::kNoTypeArguments); 184 ASSERT(field_offset != Class::kNoTypeArguments);
185 return field_offset; 185 return field_offset;
186 } 186 }
187 187
(...skipping 1095 matching lines...) Expand 10 before | Expand all | Expand 10 after
1283 __ j(EQUAL, &is_true, Assembler::kNearJump); 1283 __ j(EQUAL, &is_true, Assembler::kNearJump);
1284 __ LoadObject(EAX, bool_false); 1284 __ LoadObject(EAX, bool_false);
1285 __ ret(); 1285 __ ret();
1286 __ Bind(&is_true); 1286 __ Bind(&is_true);
1287 __ LoadObject(EAX, bool_true); 1287 __ LoadObject(EAX, bool_true);
1288 __ ret(); 1288 __ ret();
1289 return true; 1289 return true;
1290 } 1290 }
1291 1291
1292 1292
1293 static const char* kFixedSizeArrayIteratorClassName = "FixedSizeArrayIterator"; 1293 static const char* kFixedSizeArrayIteratorClassName = "_FixedSizeArrayIterator";
1294 1294
1295 1295
1296 // Class 'FixedSizeArrayIterator': 1296 // Class 'FixedSizeArrayIterator':
1297 // T next() { 1297 // T next() {
1298 // return _array[_pos++]; 1298 // return _array[_pos++];
1299 // } 1299 // }
1300 // Intrinsify: return _array[_pos++]; 1300 // Intrinsify: return _array[_pos++];
1301 // TODO(srdjan): Throw a 'NoMoreElementsException' exception if the iterator 1301 // TODO(srdjan): Throw a 'NoMoreElementsException' exception if the iterator
1302 // has no more elements. 1302 // has no more elements.
1303 bool Intrinsifier::FixedSizeArrayIterator_next(Assembler* assembler) { 1303 bool Intrinsifier::FixedSizeArrayIterator_next(Assembler* assembler) {
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
1428 __ Bind(&is_true); 1428 __ Bind(&is_true);
1429 __ LoadObject(EAX, bool_true); 1429 __ LoadObject(EAX, bool_true);
1430 __ ret(); 1430 __ ret();
1431 return true; 1431 return true;
1432 } 1432 }
1433 1433
1434 #undef __ 1434 #undef __
1435 } // namespace dart 1435 } // namespace dart
1436 1436
1437 #endif // defined TARGET_ARCH_IA32 1437 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698