Issue 10990053: [dart2dart] Force-compile top-level elements in libraries to get local members correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10990053: [dart2dart] Force-compile top-level elements in libraries to get local members correctly. (Closed)

Created:
8 years, 2 months ago by Roman

Modified:
8 years, 2 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

[dart2dart] Force-compile top-level elements in libraries to get local members correctly. This fixes swarm. Committed: https://code.google.com/p/dart/source/detail?r=12912

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	M	lib/compiler/implementation/dart_backend/backend.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	tests/compiler/dart2js/dart_backend_test.dart	View		4 chunks	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

LGTM https://codereview.chromium.org/10990053/diff/1/lib/compiler/implementation/dart_backend/backend.dart File lib/compiler/implementation/dart_backend/backend.dart (right): https://codereview.chromium.org/10990053/diff/1/lib/compiler/implementation/dart_backend/backend.dart#newcode222 lib/compiler/implementation/dart_backend/backend.dart:222: element.parseNode(compiler); Feels somewhat like a hack. May you ...

8 years, 2 months ago (2012-09-26 13:49:47 UTC) #2

Roman

8 years, 2 months ago (2012-09-26 14:00:34 UTC) #3

https://codereview.chromium.org/10990053/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://codereview.chromium.org/10990053/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart_backend/backend.dart:222:
element.parseNode(compiler);
On 2012/09/26 13:49:47, Anton Muhin wrote:
> Feels somewhat like a hack.  May you add a TODO to investigate if there is
> better way with AAR team?

Done.

Expand Messages | Collapse Messages

Issue 10990053: [dart2dart] Force-compile top-level elements in libraries to get local members correctly. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages