Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 10990053: [dart2dart] Force-compile top-level elements in libraries to get local members correctly. (Closed)

Created:
8 years, 2 months ago by Roman
Modified:
8 years, 2 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[dart2dart] Force-compile top-level elements in libraries to get local members correctly. This fixes swarm. Committed: https://code.google.com/p/dart/source/detail?r=12912

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M lib/compiler/implementation/dart_backend/backend.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 4 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roman
8 years, 2 months ago (2012-09-26 12:33:45 UTC) #1
Anton Muhin
LGTM https://codereview.chromium.org/10990053/diff/1/lib/compiler/implementation/dart_backend/backend.dart File lib/compiler/implementation/dart_backend/backend.dart (right): https://codereview.chromium.org/10990053/diff/1/lib/compiler/implementation/dart_backend/backend.dart#newcode222 lib/compiler/implementation/dart_backend/backend.dart:222: element.parseNode(compiler); Feels somewhat like a hack. May you ...
8 years, 2 months ago (2012-09-26 13:49:47 UTC) #2
Roman
8 years, 2 months ago (2012-09-26 14:00:34 UTC) #3
https://codereview.chromium.org/10990053/diff/1/lib/compiler/implementation/d...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://codereview.chromium.org/10990053/diff/1/lib/compiler/implementation/d...
lib/compiler/implementation/dart_backend/backend.dart:222:
element.parseNode(compiler);
On 2012/09/26 13:49:47, Anton Muhin wrote:
> Feels somewhat like a hack.  May you add a TODO to investigate if there is
> better way with AAR team?

Done.

Powered by Google App Engine
This is Rietveld 408576698