Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1099003002: Add --running-as-hooks argument to install-debian.wheezy.sysroot.py (Closed)

Created:
5 years, 8 months ago by Sam Clegg
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@nacl_sdk_chroot
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add --running-as-hooks argument to install-debian.wheezy.sysroot.py Previously this was called --linux-only which was a little misleading since this flag is really used to detect when it running via the hooks. Committed: https://crrev.com/95c267180c42307f6652d6a6c19c66c09ff2e017 Cr-Commit-Position: refs/heads/master@{#329579}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py View 1 2 3 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Sam Clegg
5 years, 7 months ago (2015-05-13 00:36:25 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099003002/20001
5 years, 7 months ago (2015-05-13 00:36:35 UTC) #4
Lei Zhang
https://codereview.chromium.org/1099003002/diff/20001/chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py File chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py (right): https://codereview.chromium.org/1099003002/diff/20001/chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py#newcode104 chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py:104: if options.running_as_hook and target_arch != 'arm' : nit: extra ...
5 years, 7 months ago (2015-05-13 01:04:48 UTC) #5
Sam Clegg
https://codereview.chromium.org/1099003002/diff/20001/chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py File chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py (right): https://codereview.chromium.org/1099003002/diff/20001/chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py#newcode104 chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py:104: if options.running_as_hook and target_arch != 'arm' : On 2015/05/13 ...
5 years, 7 months ago (2015-05-13 01:13:23 UTC) #6
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-13 01:25:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099003002/40001
5 years, 7 months ago (2015-05-13 01:32:42 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 03:20:15 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 03:20:56 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95c267180c42307f6652d6a6c19c66c09ff2e017
Cr-Commit-Position: refs/heads/master@{#329579}

Powered by Google App Engine
This is Rietveld 408576698