Chromium Code Reviews
Help | Chromium Project | Sign in
(232)

Issue 10990023: make: drop all system tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Torne
Modified:
1 year, 6 months ago
CC:
gyp-developer_googlegroups.com
Base URL:
http://git.chromium.org/external/gyp.git@master
Visibility:
Public.

Description

make: drop all system tests

Rather than probing for ARFLAGS at gyp time, just always use "crsT".
Linux and Android (the two platforms that used ARFLAGS) both support
thin archives, so there is no need to test for it.

BUG=gyp:250
Committed: https://code.google.com/p/gyp/source/detail?r=1507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -112 lines) Lint Patch
M pylib/gyp/generator/make.py View 7 chunks +2 lines, -43 lines 0 comments ? errors Download
M pylib/gyp/generator/ninja.py View 1 chunk +0 lines, -1 line 0 comments ? errors Download
D pylib/gyp/system_test.py View 1 chunk +0 lines, -68 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 7
Torne
Hi Evan, I've tested this on Linux and Android and it works fine. Mac is ...
1 year, 6 months ago #1
Torne
Nico, can you comment on this?
1 year, 6 months ago #2
Nico (ooo Apr 18 - Apr 20)
Thin archives weren't supported on all linuxes when we added it. How many distros did ...
1 year, 6 months ago #3
Torne
On 2012/09/26 12:59:16, Nico wrote: > Thin archives weren't supported on all linuxes when we ...
1 year, 6 months ago #4
Nico (ooo Apr 18 - Apr 20)
On 2012/09/26 13:13:37, Torne wrote: > On 2012/09/26 12:59:16, Nico wrote: > > Thin archives ...
1 year, 6 months ago #5
Torne
On 2012/09/26 13:37:49, Nico wrote: > On 2012/09/26 13:13:37, Torne wrote: > > On 2012/09/26 ...
1 year, 6 months ago #6
Nico (ooo Apr 18 - Apr 20)
1 year, 6 months ago #7
On 2012/09/26 13:42:42, Torne wrote:
> On 2012/09/26 13:37:49, Nico wrote:
> > On 2012/09/26 13:13:37, Torne wrote:
> > > On 2012/09/26 12:59:16, Nico wrote:
> > > > Thin archives weren't supported on all linuxes when we added it. How
many
> > > > distros did you test?
> > > 
> > > Just my workstation (ubuntu 10.04). I thought we couldn't build without
thin
> > > archives any more on Linux.. that was why the previous CL got reverted
that
> > > hardcoded 'crs'.
> > 
> > Which previous CL? Thin archives should be a performance-only thing as far
as
> I
> > understand, and shouldn't change behavior. Hm, I guess 32bit linkers could
> > out-of-memory without it.
> 
> https://chromiumcodereview.appspot.com/9414019 was the previous CL by evan,
> reverted (also by evan) in r1208 because "Chrome builds rely on thin
archives."
> 
> > > Thin archive support was added in binutils 2.19, released in late 2008.
Even
> > > debian stable has it :)
> > 
> > ok lgtm, let's see what breaks :-)
> 
> OK, I'll land this and then make another CL to roll it into chromium?

sgtm

> 
> > (From the bug: """Skia is interested in building a static library that can
be
> > linked against outside of gyp.  We need a way to optionally build a target
as
> a
> > "fat" archive.  Right now, it looks like there's no way around the
hard-coded
> -T
> > flag.  Is there, or will there be, a workaround?  Making local changes
doesn't
> > cut it.""" -- but I guess that doesn't get worse with this CL)
> 
> Yeah, you can't actually configure it with or without this, and I don't
> desperately want to solve that one right now (I want thin archive support on
> android because our builders are having disk and performance issues).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6