Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1098963003: Provide extra logging for GN's write_file on Windows (Closed)

Created:
5 years, 8 months ago by brettw
Modified:
5 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, tfarina, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide extra logging for GN's write_file on Windows Adds a copied version of base::WriteFile with extra logging turned on, and the FILE_SHARE_READ flag set which speculatively might fix the issue. BUG=468437 Committed: https://crrev.com/1e5dd4e4a30f5a239c42630e2bf04e61bb7a6b24 Cr-Commit-Position: refs/heads/master@{#326663}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
M tools/gn/function_write_file.cc View 1 2 3 chunks +47 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
brettw
5 years, 8 months ago (2015-04-23 20:50:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098963003/1
5 years, 8 months ago (2015-04-23 20:51:42 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/1098963003/diff/1/tools/gn/function_write_file.cc File tools/gn/function_write_file.cc (right): https://codereview.chromium.org/1098963003/diff/1/tools/gn/function_write_file.cc#newcode28 tools/gn/function_write_file.cc:28: base::win::ScopedHandle file(CreateFile( ::CreateFile for consistency with ::WriteFile. :)
5 years, 8 months ago (2015-04-23 20:55:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098963003/20001
5 years, 8 months ago (2015-04-23 20:56:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/45974)
5 years, 8 months ago (2015-04-23 21:07:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098963003/40001
5 years, 8 months ago (2015-04-23 21:13:28 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-23 22:00:35 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 22:02:23 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1e5dd4e4a30f5a239c42630e2bf04e61bb7a6b24
Cr-Commit-Position: refs/heads/master@{#326663}

Powered by Google App Engine
This is Rietveld 408576698