Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1098953005: ServiceWorker: Add UMA for Activate and Install event results. (Closed)

Created:
5 years, 8 months ago by falken
Modified:
5 years, 8 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, asvitkine+watch_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Add UMA for Activate and Install event results. We want to change activate so that rejecting the waitUntil promise is the same as resolving it. Adding UMA to get an idea of the impact of the change. It could be useful to have this data anyway, so also adding it for Install. BUG=480050 Committed: https://crrev.com/375d6d1dfc251498b878c71574a24494bdb18216 Cr-Commit-Position: refs/heads/master@{#326925}

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M content/browser/service_worker/service_worker_metrics.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
falken
ptal
5 years, 8 months ago (2015-04-24 03:11:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098953005/20001
5 years, 8 months ago (2015-04-24 04:00:21 UTC) #4
nhiroki
lgtm
5 years, 8 months ago (2015-04-24 04:01:33 UTC) #5
falken
+asvitkine for histograms
5 years, 8 months ago (2015-04-24 04:05:26 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-24 05:00:32 UTC) #9
Alexei Svitkine (slow)
lgtm
5 years, 8 months ago (2015-04-24 16:06:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098953005/20001
5 years, 8 months ago (2015-04-24 23:04:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 23:05:04 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 23:06:24 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/375d6d1dfc251498b878c71574a24494bdb18216
Cr-Commit-Position: refs/heads/master@{#326925}

Powered by Google App Engine
This is Rietveld 408576698