Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1098953003: HeapTest.HeapVectorPartObjects: fix reserveCapacity() expectation. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

HeapTest.HeapVectorPartObjects: fix reserveCapacity() expectation. The size argument to reserveCapacity() is a lower bound, adjust the tests accordingly. TBR=haraken,tkent BUG=475801 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/platform/heap/HeapTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look. Unit test added by r194100 is failing on the nexus4 bot, ...
5 years, 8 months ago (2015-04-21 13:52:06 UTC) #2
sof
TBRing this unit test change, so as to try to avoid revert churn.
5 years, 8 months ago (2015-04-21 14:27:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098953003/1
5 years, 8 months ago (2015-04-21 14:36:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194138
5 years, 8 months ago (2015-04-21 15:17:04 UTC) #6
haraken
5 years, 8 months ago (2015-04-21 15:21:01 UTC) #7
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698