Handle receiving GrowableObjectArrays correctly on native ports

runtime/vm/snapshot_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_debugger_api.h"
 #include "platform/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_message.h"
@@ skipping 1312 matching lines @@
       "final int kArrayLength = 10;\n"
       "getList() {\n"
       "  return [null, null, null, null, null, null, null, null, null, null];\n"
       "}\n"
       "getIntList() {\n"
       "  return [0, 1, 2, 3, 4, 5, 6, 7, 8, 9];\n"
       "}\n"
       "getStringList() {\n"
       "  return ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9'];\n"
       "}\n"
+      "getListList() {\n"
+      "  return [[],"
+      "          [0],"
+      "          [0, 1],"
+      "          [0, 1, 2],"
+      "          [0, 1, 2, 3],"
+      "          [0, 1, 2, 3, 4],"
+      "          [0, 1, 2, 3, 4, 5],"
+      "          [0, 1, 2, 3, 4, 5, 6],"
+      "          [0, 1, 2, 3, 4, 5, 6, 7],"
+      "          [0, 1, 2, 3, 4, 5, 6, 7, 8]];\n"
+      "}\n"
       "getMixedList() {\n"
       "  var list = [];\n"
       "  list.add(0);\n"
       "  list.add('1');\n"
       "  list.add(2.2);\n"
       "  list.add(true);\n"
-      "  list.add(null);\n"
-      "  list.add(null);\n"
-      "  list.add(null);\n"
-      "  list.add(null);\n"
-      "  list.add(null);\n"
-      "  list.add(null);\n"
+      "  list.add([]);\n"
+      "  list.add([[]]);\n"
+      "  list.add([[[]]]);\n"
+      "  list.add([1, [2, [3]]]);\n"
+      "  list.add([1, [1, 2, [1, 2, 3]]]);\n"
+      "  list.add([1, 2, 3]);\n"
       "  return list;\n"
       "}\n";
 
   TestCase::CreateTestIsolate();
   Isolate* isolate = Isolate::Current();
   EXPECT(isolate != NULL);
   Dart_EnterScope();
 
   Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
   EXPECT_VALID(lib);
@@ skipping 33 matching lines @@
       EXPECT_EQ(Dart_CObject::kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
       for (int i = 0; i < kArrayLength; i++) {
         EXPECT_EQ(Dart_CObject::kString, root->value.as_array.values[i]->type);
         char buffer[3];
         snprintf(buffer, sizeof(buffer), "%d", i);
         EXPECT_STREQ(buffer, root->value.as_array.values[i]->value.as_string);
       }
     }
     {
+      // Generate a list of lists from Dart code.
+      ApiNativeScope scope;
+      Dart_CObject* root = GetDeserializedDartMessage(lib, "getListList");
+      EXPECT_NOTNULL(root);
+      EXPECT_EQ(Dart_CObject::kArray, root->type);
+      EXPECT_EQ(kArrayLength, root->value.as_array.length);
+      for (int i = 0; i < kArrayLength; i++) {
+        Dart_CObject* element = root->value.as_array.values[i];
+        EXPECT_EQ(Dart_CObject::kArray, element->type);
+        EXPECT_EQ(i, element->value.as_array.length);
+        for (int j = 0; j < i; j++) {
+          EXPECT_EQ(Dart_CObject::kInt32,
+                    element->value.as_array.values[j]->type);
+          EXPECT_EQ(j, element->value.as_array.values[j]->value.as_int32);
+        }
+      }
+    }
+    {
       // Generate a list of objects of different types from Dart code.
       ApiNativeScope scope;
       Dart_CObject* root = GetDeserializedDartMessage(lib, "getMixedList");
       EXPECT_NOTNULL(root);
       EXPECT_EQ(Dart_CObject::kArray, root->type);
       EXPECT_EQ(kArrayLength, root->value.as_array.length);
 
       EXPECT_EQ(Dart_CObject::kInt32, root->value.as_array.values[0]->type);
       EXPECT_EQ(0, root->value.as_array.values[0]->value.as_int32);
       EXPECT_EQ(Dart_CObject::kString, root->value.as_array.values[1]->type);
       EXPECT_STREQ("1", root->value.as_array.values[1]->value.as_string);
       EXPECT_EQ(Dart_CObject::kDouble, root->value.as_array.values[2]->type);
       EXPECT_EQ(2.2, root->value.as_array.values[2]->value.as_double);
       EXPECT_EQ(Dart_CObject::kBool, root->value.as_array.values[3]->type);
       EXPECT_EQ(true, root->value.as_array.values[3]->value.as_bool);
 
       for (int i = 0; i < kArrayLength; i++) {
         if (i > 3) {
-          EXPECT_EQ(Dart_CObject::kNull, root->value.as_array.values[i]->type);
+          EXPECT_EQ(Dart_CObject::kArray, root->value.as_array.values[i]->type);
         }
       }
+
+      Dart_CObject* element;
+      Dart_CObject* e;
+
+      // []
+      element = root->value.as_array.values[4];
+      EXPECT_EQ(0, element->value.as_array.length);
+
+      // [[]]
+      element = root->value.as_array.values[5];
+      EXPECT_EQ(1, element->value.as_array.length);
+      element = element->value.as_array.values[0];
+      EXPECT_EQ(Dart_CObject::kArray, element->type);
+      EXPECT_EQ(0, element->value.as_array.length);
+
+      // [[[]]]"
+      element = root->value.as_array.values[6];
+      EXPECT_EQ(1, element->value.as_array.length);
+      element = element->value.as_array.values[0];
+      EXPECT_EQ(Dart_CObject::kArray, element->type);
+      EXPECT_EQ(1, element->value.as_array.length);
+      element = element->value.as_array.values[0];
+      EXPECT_EQ(Dart_CObject::kArray, element->type);
+      EXPECT_EQ(0, element->value.as_array.length);
+
+      // [1, [2, [3]]]
+      element = root->value.as_array.values[7];
+      EXPECT_EQ(2, element->value.as_array.length);
+      e = element->value.as_array.values[0];
+      EXPECT_EQ(Dart_CObject::kInt32, e->type);
+      EXPECT_EQ(1, e->value.as_int32);
+      element = element->value.as_array.values[1];
+      EXPECT_EQ(Dart_CObject::kArray, element->type);
+      EXPECT_EQ(2, element->value.as_array.length);
+      e = element->value.as_array.values[0];
+      EXPECT_EQ(Dart_CObject::kInt32, e->type);
+      EXPECT_EQ(2, e->value.as_int32);
+      element = element->value.as_array.values[1];
+      EXPECT_EQ(Dart_CObject::kArray, element->type);
+      EXPECT_EQ(1, element->value.as_array.length);
+      e = element->value.as_array.values[0];
+      EXPECT_EQ(Dart_CObject::kInt32, e->type);
+      EXPECT_EQ(3, e->value.as_int32);
+
+      // [1, [1, 2, [1, 2, 3]]]
+      element = root->value.as_array.values[8];
+      EXPECT_EQ(2, element->value.as_array.length);
+      e = element->value.as_array.values[0];
+      EXPECT_EQ(Dart_CObject::kInt32, e->type);
+      e = element->value.as_array.values[0];
+      EXPECT_EQ(Dart_CObject::kInt32, e->type);
+      EXPECT_EQ(1, e->value.as_int32);
+      element = element->value.as_array.values[1];
+      EXPECT_EQ(Dart_CObject::kArray, element->type);
+      EXPECT_EQ(3, element->value.as_array.length);
+      for (int i = 0; i < 2; i++) {
+        e = element->value.as_array.values[i];
+        EXPECT_EQ(Dart_CObject::kInt32, e->type);
+        EXPECT_EQ(i + 1, e->value.as_int32);
+      }
+      element = element->value.as_array.values[2];
+      EXPECT_EQ(Dart_CObject::kArray, element->type);
+      EXPECT_EQ(3, element->value.as_array.length);
+      for (int i = 0; i < 3; i++) {
+        e = element->value.as_array.values[i];
+        EXPECT_EQ(Dart_CObject::kInt32, e->type);
+        EXPECT_EQ(i + 1, e->value.as_int32);
+      }
+
+      // [1, 2, 3]
+      element = root->value.as_array.values[9];
+      EXPECT_EQ(3, element->value.as_array.length);
+      for (int i = 0; i < 3; i++) {
+        e = element->value.as_array.values[i];
+        EXPECT_EQ(Dart_CObject::kInt32, e->type);
+        EXPECT_EQ(i + 1, e->value.as_int32);
+      }
     }
   }
   Dart_ExitScope();
   Dart_ShutdownIsolate();
 }
 
 
 UNIT_TEST_CASE(DartGeneratedListMessagesWithBackref) {
   const int kArrayLength = 10;
   static const char* kScriptChars =
@@ skipping 430 matching lines @@
   EXPECT(Dart_ErrorHasException(result));
   EXPECT_SUBSTRING("Exception: nulltruefalse1234563.14[]100123456789\n",
                    Dart_GetError(result));
 
   Dart_ExitScope();
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart