Changed DB to store node positions as Ordinals.

sync/syncable/directory_backing_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 #include <string>
 
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 2061 matching lines @@
   Directory::KernelLoadInfo load_info;
 
   ASSERT_TRUE(dbs->Load(&entry_bucket, &load_info));
   // Check that the initial value is the serialization of an empty ChipBag.
   sync_pb::ChipBag chip_bag;
   std::string serialized_chip_bag;
   ASSERT_TRUE(chip_bag.SerializeToString(&serialized_chip_bag));
   EXPECT_EQ(serialized_chip_bag, load_info.kernel_info.bag_of_chips);
 }
 
+TEST_F(DirectoryBackingStoreTest, MigrateVersion80To81) {
+  sql::Connection connection;
+  ASSERT_TRUE(connection.OpenInMemory());
+
+  // Unfortunately there isn't a SetUpVersion80Database to use

[rlarocque, 2012/09/27 23:10:12]

You should fix this.  I believe it was Nicolas who added the bag of chips.  You
should ask him about its effects on the database format.

+  // and I (vishwath) don't know enough about the bag_of_chips
+  // to write it myself (yet). So assuming the previous test
+  // passed, create at ver 79 and migrate up to 81 instead.
+  SetupVersion79Database(&connection);
+
+  sql::Statement s(connection.GetUniqueStatement(
+      "SELECT id FROM metas WHERE unique_server_tag = 'google_chrome'"));
+  ASSERT_TRUE(s.Step());
+  ASSERT_EQ(s.ColumnType(3), COLUMN_TYPE_INTEGER);
+
+  scoped_ptr<TestDirectoryBackingStore> dbs(
+      new TestDirectoryBackingStore(GetUsername(), &connection));
+  ASSERT_TRUE(dbs->MigrateVersion79To80());
+  ASSERT_TRUE(dbs->MigrateVersion80To81());
+
+  sql::Statement s(connection.GetUniqueStatement(
+      "SELECT id FROM metas WHERE unique_server_tag = 'google_chrome'"));
+  ASSERT_TRUE(s.Step());
+  ASSERT_EQ(s.ColumnType(3), COLUMN_TYPE_TEXT);

[rlarocque, 2012/09/27 23:10:12]

Shouldn't you check the values stored in the column aren't corrupted by the
migration, or is that handled elsewhere?

+}
+
 TEST_P(MigrationTest, ToCurrentVersion) {
   sql::Connection connection;
   ASSERT_TRUE(connection.OpenInMemory());
   switch (GetParam()) {
     case 67:
       SetUpVersion67Database(&connection);
       break;
     case 68:
       SetUpVersion68Database(&connection);
       break;
@@ skipping 360 matching lines @@
   const std::string& guid2 = TestDirectoryBackingStore::GenerateCacheGUID();
   EXPECT_EQ(24U, guid1.size());
   EXPECT_EQ(24U, guid2.size());
   // In theory this test can fail, but it won't before the universe
   // dies of heat death.
   EXPECT_NE(guid1, guid2);
 }
 
 }  // namespace syncable
 }  // namespace syncer