Issue 10989047: Add docs as default app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10989047: Add docs as default app (Closed)

Created:
8 years, 2 months ago by Gaurav

Modified:
8 years, 2 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), mihaip-chromium-reviews_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

Add Docs as a default app. BUG=151379 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159110

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, --1 lines)			Patch
M	build/common.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/default_apps/docs.crx	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/default_apps/external_extensions.json	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

LGTM I'll need to land this, since the CQ doesn't handle .crx (or other binary) ...

8 years, 2 months ago (2012-09-27 18:03:37 UTC) #2

Mihai Parparita -not on Chrome

8 years, 2 months ago (2012-09-27 20:43:44 UTC) #3

On 2012/09/27 18:03:37, Mihai Parparita wrote:
> LGTM
> 
> I'll need to land this, since the CQ doesn't handle .crx (or other binary)
> files.

Landed as http://crrev.com/159110

Expand Messages | Collapse Messages