Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: utils/pub/system_cache.dart

Issue 10989013: Change IllegalArgumentException to ArgumentError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated co19 test expectations. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library('system_cache'); 5 #library('system_cache');
6 6
7 #import('io.dart'); 7 #import('io.dart');
8 #import('package.dart'); 8 #import('package.dart');
9 #import('source.dart'); 9 #import('source.dart');
10 #import('source_registry.dart'); 10 #import('source_registry.dart');
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 52
53 /** 53 /**
54 * Ensures that the package identified by [id] is installed to the cache, 54 * Ensures that the package identified by [id] is installed to the cache,
55 * loads it, and returns it. 55 * loads it, and returns it.
56 * 56 *
57 * It is an error to try installing a package from a source with `shouldCache 57 * It is an error to try installing a package from a source with `shouldCache
58 * == false` to the system cache. 58 * == false` to the system cache.
59 */ 59 */
60 Future<Package> install(PackageId id) { 60 Future<Package> install(PackageId id) {
61 if (!id.source.shouldCache) { 61 if (!id.source.shouldCache) {
62 throw new IllegalArgumentException("Package $id is not cacheable."); 62 throw new ArgumentError("Package $id is not cacheable.");
63 } 63 }
64 64
65 var pending = _pendingInstalls[id]; 65 var pending = _pendingInstalls[id];
66 if (pending != null) return pending; 66 if (pending != null) return pending;
67 67
68 var future = id.source.installToSystemCache(id); 68 var future = id.source.installToSystemCache(id);
69 always(future, () => _pendingInstalls.remove(id)); 69 always(future, () => _pendingInstalls.remove(id));
70 _pendingInstalls[id] = future; 70 _pendingInstalls[id] = future;
71 return future; 71 return future;
72 } 72 }
73 } 73 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698