Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: pkg/unittest/string_matchers.dart

Issue 10989013: Change IllegalArgumentException to ArgumentError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated co19 test expectations. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Returns a matcher which matches if the match argument is a string and 6 * Returns a matcher which matches if the match argument is a string and
7 * is equal to [value] when compared case-insensitively. 7 * is equal to [value] when compared case-insensitively.
8 */ 8 */
9 Matcher equalsIgnoringCase(String value) => new _IsEqualIgnoringCase(value); 9 Matcher equalsIgnoringCase(String value) => new _IsEqualIgnoringCase(value);
10 10
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 164
165 class _MatchesRegExp extends _StringMatcher { 165 class _MatchesRegExp extends _StringMatcher {
166 RegExp _regexp; 166 RegExp _regexp;
167 167
168 _MatchesRegExp(re) { 168 _MatchesRegExp(re) {
169 if (re is String) { 169 if (re is String) {
170 _regexp = new RegExp(re); 170 _regexp = new RegExp(re);
171 } else if (re is RegExp) { 171 } else if (re is RegExp) {
172 _regexp = re; 172 _regexp = re;
173 } else { 173 } else {
174 throw new IllegalArgumentException('matches requires a regexp or string'); 174 throw new ArgumentError('matches requires a regexp or string');
175 } 175 }
176 } 176 }
177 177
178 bool matches(String item, MatchState matchState) => 178 bool matches(String item, MatchState matchState) =>
179 _regexp.hasMatch(item); 179 _regexp.hasMatch(item);
180 180
181 Description describe(Description description) => 181 Description describe(Description description) =>
182 description.add("match '${_regexp.pattern}'"); 182 description.add("match '${_regexp.pattern}'");
183 } 183 }
184 184
185 // String matchers match against a string. We add this intermediate 185 // String matchers match against a string. We add this intermediate
186 // class to give better mismatch error messages than the base Matcher class. 186 // class to give better mismatch error messages than the base Matcher class.
187 /* abstract */ class _StringMatcher extends BaseMatcher { 187 /* abstract */ class _StringMatcher extends BaseMatcher {
188 const _StringMatcher(); 188 const _StringMatcher();
189 Description describeMismatch(item, Description mismatchDescription, 189 Description describeMismatch(item, Description mismatchDescription,
190 MatchState matchState, bool verbose) { 190 MatchState matchState, bool verbose) {
191 if (!(item is String)) { 191 if (!(item is String)) {
192 return mismatchDescription. 192 return mismatchDescription.
193 addDescriptionOf(item). 193 addDescriptionOf(item).
194 add(' not a string'); 194 add(' not a string');
195 } else { 195 } else {
196 return super.describeMismatch(item, mismatchDescription, 196 return super.describeMismatch(item, mismatchDescription,
197 matchState, verbose); 197 matchState, verbose);
198 } 198 }
199 } 199 }
200 } 200 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698