Change IllegalArgumentException to ArgumentError.

pkg/args/test/args_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('args_test');
 
 #import('../../unittest/unittest.dart');
 
 // TODO(rnystrom): Use "package:" URL here when test.dart can handle pub.
 #import('../lib/args.dart');
 
 main() {
   group('ArgParser.addFlag()', () {
-    test('throws IllegalArgumentException if the flag already exists', () {
+    test('throws ArgumentError if the flag already exists', () {
       var parser = new ArgParser();
       parser.addFlag('foo');
       throwsIllegalArg(() => parser.addFlag('foo'));
     });
 
-    test('throws IllegalArgumentException if the option already exists', () {
+    test('throws ArgumentError if the option already exists', () {
       var parser = new ArgParser();
       parser.addOption('foo');
       throwsIllegalArg(() => parser.addFlag('foo'));
     });
 
-    test('throws IllegalArgumentException if the abbreviation exists', () {
+    test('throws ArgumentError if the abbreviation exists', () {
       var parser = new ArgParser();
       parser.addFlag('foo', abbr: 'f');
       throwsIllegalArg(() => parser.addFlag('flummox', abbr: 'f'));
     });
 
-    test('throws IllegalArgumentException if the abbreviation is longer '
+    test('throws ArgumentError if the abbreviation is longer '
          'than one character', () {
       var parser = new ArgParser();
       throwsIllegalArg(() => parser.addFlag('flummox', abbr: 'flu'));
     });
   });
 
   group('ArgParser.addOption()', () {
-    test('throws IllegalArgumentException if the flag already exists', () {
+    test('throws ArgumentError if the flag already exists', () {
       var parser = new ArgParser();
       parser.addFlag('foo');
       throwsIllegalArg(() => parser.addOption('foo'));
     });
 
-    test('throws IllegalArgumentException if the option already exists', () {
+    test('throws ArgumentError if the option already exists', () {
       var parser = new ArgParser();
       parser.addOption('foo');
       throwsIllegalArg(() => parser.addOption('foo'));
     });
 
-    test('throws IllegalArgumentException if the abbreviation exists', () {
+    test('throws ArgumentError if the abbreviation exists', () {
       var parser = new ArgParser();
       parser.addFlag('foo', abbr: 'f');
       throwsIllegalArg(() => parser.addOption('flummox', abbr: 'f'));
     });
 
-    test('throws IllegalArgumentException if the abbreviation is longer '
+    test('throws ArgumentError if the abbreviation is longer '
          'than one character', () {
       var parser = new ArgParser();
       throwsIllegalArg(() => parser.addOption('flummox', abbr: 'flu'));
     });
   });
 
   group('ArgParser.parse()', () {
     group('flags', () {
       test('are true if present', () {
         var parser = new ArgParser();
@@ skipping 358 matching lines @@
         var args = parser.parse(['']);
         expect(args['define'], equals(['0']));
       });
     });
 
     group('query default values', () {
       test('queries the default value', () {
         var parser = new ArgParser();
         parser.addOption('define', defaultsTo: '0');
         expect(()=>parser.getDefault('undefine'),
-            throwsIllegalArgumentException);
+            throwsArgumentError);
       });
 
       test('queries the default value for an unknown option', () {
         var parser = new ArgParser();
         parser.addOption('define', defaultsTo: '0');
         expect(()=>parser.getDefault('undefine'),
-            throwsIllegalArgumentException);
+            throwsArgumentError);
       });
     });
 
     group('gets the option names from an ArgsResult', () {
       test('queries the set options', () {
         var parser = new ArgParser();
         parser.addFlag('woof', defaultsTo: false);
         parser.addOption('meow', defaultsTo: 'kitty');
         var args = parser.parse([]);
         expect(args.options, hasLength(2));
@@ skipping 202 matching lines @@
   group('ArgResults[]', () {
     test('throws if the name is not an option', () {
       var parser = new ArgParser();
       var results = parser.parse([]);
       throwsIllegalArg(() => results['unknown']);
     });
   });
 }
 
 throwsIllegalArg(function) {
-  expect(function, throwsIllegalArgumentException);
+  expect(function, throwsArgumentError);
 }
 
 throwsFormat(ArgParser parser, List<String> args) {
   expect(() => parser.parse(args), throwsFormatException);
 }
 
 validateUsage(ArgParser parser, String expected) {
   expected = unindentString(expected);
   expect(parser.getUsage(), equals(expected));
 }
 
 // TODO(rnystrom): Replace one in test_utils.
 String unindentString(String text) {
   var lines = text.split('\n');
 
   // Count the indentation of the last line.
   var whitespace = const RegExp('^ *');
   var indent = whitespace.firstMatch(lines[lines.length - 1])[0].length;
 
   // Drop the last line. It only exists for specifying indentation.
   lines.removeLast();
 
   // Strip indentation from the remaining lines.
   for (var i = 0; i < lines.length; i++) {
     var line = lines[i];
     if (line.length <= indent) {
       // It's short, so it must be nothing but whitespace.
       if (line.trim() != '') {
-        throw new IllegalArgumentException(
+        throw new ArgumentError(
             'Line "$line" does not have enough indentation.');
       }
 
       lines[i] = '';
     } else {
       if (line.substring(0, indent).trim() != '') {
-        throw new IllegalArgumentException(
+        throw new ArgumentError(
             'Line "$line" does not have enough indentation.');
       }
 
       lines[i] = line.substring(indent);
     }
   }
 
   return Strings.join(lines, '\n');
 }