Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: lib/coreimpl/arrays.dart

Issue 10989013: Change IllegalArgumentException to ArgumentError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated co19 test expectations. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // TODO(ngeoffray): Rename to Lists. 5 // TODO(ngeoffray): Rename to Lists.
6 class Arrays { 6 class Arrays {
7 static void copy(List src, int srcStart, 7 static void copy(List src, int srcStart,
8 List dst, int dstStart, int count) { 8 List dst, int dstStart, int count) {
9 if (srcStart === null) srcStart = 0; 9 if (srcStart === null) srcStart = 0;
10 if (dstStart === null) dstStart = 0; 10 if (dstStart === null) dstStart = 0;
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 for (int i = startIndex; i >= 0; i--) { 71 for (int i = startIndex; i >= 0; i--) {
72 if (a[i] == element) { 72 if (a[i] == element) {
73 return i; 73 return i;
74 } 74 }
75 } 75 }
76 return -1; 76 return -1;
77 } 77 }
78 78
79 static void rangeCheck(List a, int start, int length) { 79 static void rangeCheck(List a, int start, int length) {
80 if (length < 0) { 80 if (length < 0) {
81 throw new IllegalArgumentException("negative length $length"); 81 throw new ArgumentError("negative length $length");
82 } 82 }
83 if (start < 0 ) { 83 if (start < 0 ) {
84 String message = "$start must be greater than or equal to 0"; 84 String message = "$start must be greater than or equal to 0";
85 throw new IndexOutOfRangeException(message); 85 throw new IndexOutOfRangeException(message);
86 } 86 }
87 if (start + length > a.length) { 87 if (start + length > a.length) {
88 String message = "$start + $length must be in the range [0..${a.length})"; 88 String message = "$start + $length must be in the range [0..${a.length})";
89 throw new IndexOutOfRangeException(message); 89 throw new IndexOutOfRangeException(message);
90 } 90 }
91 } 91 }
92 } 92 }
93 93
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698