Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: lib/compiler/implementation/util/uri_extras.dart

Issue 10989013: Change IllegalArgumentException to ArgumentError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated co19 test expectations. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library('uri_extras'); 5 #library('uri_extras');
6 6
7 #import('dart:math'); 7 #import('dart:math');
8 #import('dart:uri'); 8 #import('dart:uri');
9 9
10 String relativize(Uri base, Uri uri, bool isWindows) { 10 String relativize(Uri base, Uri uri, bool isWindows) {
11 if (!base.path.startsWith('/')) { 11 if (!base.path.startsWith('/')) {
12 // Also throw an exception if [base] or base.path is null. 12 // Also throw an exception if [base] or base.path is null.
13 throw new IllegalArgumentException('Expected absolute path: ${base.path}'); 13 throw new ArgumentError('Expected absolute path: ${base.path}');
14 } 14 }
15 if (!uri.path.startsWith('/')) { 15 if (!uri.path.startsWith('/')) {
16 // Also throw an exception if [uri] or uri.path is null. 16 // Also throw an exception if [uri] or uri.path is null.
17 throw new IllegalArgumentException('Expected absolute path: ${uri.path}'); 17 throw new ArgumentError('Expected absolute path: ${uri.path}');
18 } 18 }
19 bool equalsNCS(String a, String b) { 19 bool equalsNCS(String a, String b) {
20 return a.toLowerCase() == b.toLowerCase(); 20 return a.toLowerCase() == b.toLowerCase();
21 } 21 }
22 22
23 String normalize(String path) { 23 String normalize(String path) {
24 if (isWindows) { 24 if (isWindows) {
25 return path.toLowerCase(); 25 return path.toLowerCase();
26 } else { 26 } else {
27 return path; 27 return path;
(...skipping 28 matching lines...) Expand all
56 sb.add('../'); 56 sb.add('../');
57 } 57 }
58 for (int i = common; i < uriParts.length - 1; i++) { 58 for (int i = common; i < uriParts.length - 1; i++) {
59 sb.add('${uriParts[i]}/'); 59 sb.add('${uriParts[i]}/');
60 } 60 }
61 sb.add('${uriParts.last()}'); 61 sb.add('${uriParts.last()}');
62 return sb.toString(); 62 return sb.toString();
63 } 63 }
64 return uri.toString(); 64 return uri.toString();
65 } 65 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698