Issue 10989: Remove base/ dependencies from ScrollbarThemeChromiumWin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10989: Remove base/ dependencies from ScrollbarThemeChromiumWin. (Closed)

Created:
12 years ago by please use my chromium address

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Remove base/ dependencies from ScrollbarThemeChromiumWin.

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -35 lines)			Patch
M	webkit/glue/chromium_bridge_impl.cc	View		2 chunks	+36 lines, -0 lines	0 comments	Download
M	webkit/port/platform/chromium/ChromiumBridge.h	View		4 chunks	+19 lines, -0 lines	0 comments	Download
M	webkit/port/platform/chromium/ScrollbarThemeChromiumWin.cpp	View	1	8 chunks	+22 lines, -35 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

12 years ago (2008-11-27 16:43:10 UTC) #2

Thanks for looking at this. I think the current plan, however, is to move
NativeTheme into RenderThemeWin in the webkit port rather than bridge out for
those calls. Then I think we would have a separate NativeTheme thingy (which
would be much simpler) for the few cases in the browser when we need this
functionality. The eventual goal is to unify Windows theme rendering in WebKit.

I think the begin/endPlatformPaint can also stay the way they are.
PlatformCanvas we're now calling part of Skia (which we have to have an external
dependency on anyway) so I think those calls can stay as well.

Expand Messages | Collapse Messages