The SQLitePersistentCookieStore should use a non-partial index on iOS.

content/browser/net/sqlite_persistent_cookie_store.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/net/sqlite_persistent_cookie_store.h"
 
 #include <list>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 414 matching lines @@
       "priority INTEGER NOT NULL DEFAULT %d,"
       "encrypted_value BLOB DEFAULT '',"
       "firstpartyonly INTEGER NOT NULL DEFAULT 0)",
       CookiePriorityToDBCookiePriority(net::COOKIE_PRIORITY_DEFAULT)));
   if (!db->Execute(stmt.c_str()))
     return false;
 
   if (!db->Execute("CREATE INDEX domain ON cookies(host_key)"))
     return false;
 
+#if defined(OS_IOS)

[rohitrao (ping after 24h), 2015/04/24 17:36:29]

Is it worth adding a comment saying why iOS is different, and which iOS version
is the first to support partial indexes?  (Put the comment in both places, if
you add it?)

[erikchen, 2015/04/24 17:42:57]

Done.

+  if (!db->Execute("CREATE INDEX is_transient ON cookies(persistent)")) {
+#else
   if (!db->Execute(
           "CREATE INDEX is_transient ON cookies(persistent) "
           "where persistent != 1")) {
+#endif
     return false;
   }
 
   return true;
 }
 
 }  // namespace
 
 void SQLitePersistentCookieStore::Backend::Load(
     const LoadedCallback& loaded_callback) {
@@ skipping 526 matching lines @@
           << "Unable to drop table cookie_times in update to version 9.";
       return false;
     }
 
     if (!db_->Execute(
         "CREATE INDEX IF NOT EXISTS domain ON cookies(host_key)")) {
       LOG(WARNING) << "Unable to create index domain in update to version 9.";
       return false;
     }
 
+#if defined(OS_IOS)
     if (!db_->Execute(
-            "CREATE INDEX IF NOT EXISTS is_transient ON cookies(persistent) "
-            "where persistent != 1")) {
+        "CREATE INDEX IF NOT EXISTS is_transient ON cookies(persistent) ")) {

[rohitrao (ping after 24h), 2015/04/24 17:36:29]

Extra trailing whitespace in the SQL command.

[erikchen, 2015/04/24 17:42:57]

Done.

+#else
+    if (!db_->Execute(
+        "CREATE INDEX IF NOT EXISTS is_transient ON cookies(persistent) "
+        "where persistent != 1")) {
+#endif
       LOG(WARNING)
           << "Unable to create index is_transient in update to version 9.";
       return false;
     }
     ++cur_version;
     meta_table_.SetVersionNumber(cur_version);
     meta_table_.SetCompatibleVersionNumber(
         std::min(cur_version, kCompatibleVersionNumber));
     transaction.Commit();
     UMA_HISTOGRAM_TIMES("Cookie.TimeDatabaseMigrationToV9",
@@ skipping 442 matching lines @@
         (config.session_cookie_mode ==
          CookieStoreConfig::RESTORED_SESSION_COOKIES)) {
       cookie_monster->SetPersistSessionCookies(true);
     }
   }
 
   return cookie_monster;
 }
 
 }  // namespace content